-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detach in scope cli #1110
Add detach in scope cli #1110
Conversation
3df4e16
to
3222d64
Compare
3222d64
to
e254093
Compare
The logic is ready to review. I am not sure which docs section should be updated/extended regarding the detach, e.g.: appscope/website/src/pages/docs/overview.md Lines 21 to 23 in 6a9106e
"Attach to processes while they are running or start when the process does." |
I get this message when re-attaching multiple times quickly ; or detaching multiple times quickly: |
If i run |
98c475f
to
a46b552
Compare
Good catch - done in 853fa85 |
I have created an issue for this: #1123 . I think this can be somehow handled by modifying creation of our file because I believe the issue is related to file sealing. I did not observe a similar problem if I change the location Line 259 in 6a9106e
/tmp
|
Ref #1107
- [ ] Handle the scenario when we attach to an already scoped process should we overwrite the scope configuration always?We overwrite the configuration during reattach