Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output the cribl section when outputting config #966

Merged
merged 2 commits into from
May 25, 2022
Merged

output the cribl section when outputting config #966

merged 2 commits into from
May 25, 2022

Conversation

jrcheli
Copy link
Contributor

@jrcheli jrcheli commented May 25, 2022

resolves #918

michalbiesek
michalbiesek approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@michalbiesek michalbiesek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrcheli The changes looks good to me. I saw that there was build problem with syscalls-alpine and alpine integration tests I have address the above in #967.

@michalbiesek michalbiesek mentioned this pull request May 25, 2022
Closed
@jrcheli jrcheli merged commit 6f33adc into master May 25, 2022
@jrcheli jrcheli deleted the feature/918-output-cribl-config branch May 25, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbiesek michalbiesek michalbiesek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For Cloud: include cribl section in configuration output
2 participants
@jrcheli @michalbiesek