Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project creation #144

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

Pocokwins
Copy link
Contributor

Identify google_project based on it's identifier provided by the remote client.
-->
Fixes #8

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I've created an image locally, which I pushed to our private repository, then I've used it in the Provider. After that I had to set up the projectId parameter for the Project resource and it has been created properly by the provider.

Copy link
Contributor

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Pocokwins for fixing this bug, lgtm. Also left a comment here and manually verified config.IdentifierFromProvider.

We also need to fix the Project example but looks like it's already broken (missing a required name parameter). I'll open a separate PR. Looks like we can also improve the appengine.Application example, which is currently missing a Project dependency.

@ulucinar
Copy link
Contributor

ulucinar commented Jan 23, 2023

Looks like we need a rebase and resolve conflicts. Will do so to make sure the fix is available with the next release.

@ulucinar
Copy link
Contributor

Hi @Pocokwins,
Looks like I don't have permissions to push into your feature branch:

remote: Permission to XXXLutz/provider-gcp.git denied to ulucinar.
fatal: unable to access 'https://github.com/XXXLutz/provider-gcp/': The requested URL returned error: 403

Could you please rebase this PR?

@Pocokwins
Copy link
Contributor Author

Hi @Pocokwins, Looks like I don't have permissions to push into your feature branch:

remote: Permission to XXXLutz/provider-gcp.git denied to ulucinar.
fatal: unable to access 'https://github.com/XXXLutz/provider-gcp/': The requested URL returned error: 403

Could you please rebase this PR?

Hi @ulucinar , sure, it's done.

@ulucinar ulucinar merged commit f95df33 into crossplane-contrib:main Jan 24, 2023
@oskisk oskisk deleted the Fix-project-creation branch January 25, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcp.project: Project cannot create projects
5 participants