Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project creation #144

Merged
merged 3 commits into from
Jan 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apis/appengine/v1beta1/zz_application_types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apis/appengine/v1beta1/zz_generated.resolvers.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions apis/cloudplatform/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions apis/cloudplatform/v1beta1/zz_project_types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion config/externalname.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ var externalNameConfigs = map[string]config.ExternalName{
// Project-ID has a format as following: projects/{{project}}
// So, the GetIDFn function implementation for project-id and import method
// for project resource seems that different.
"google_project": config.TemplatedStringAsIdentifier("project_id", "projects/{{ .external_name }}"),
"google_project": config.IdentifierFromProvider,
// Resource with format projects/{{project}}
// This resource does not support import
"google_project_default_service_accounts": TemplatedStringAsIdentifierWithNoName("projects/{{ .external_name }}"),
Expand Down
1 change: 1 addition & 0 deletions examples-generated/appengine/application.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ spec:
forProvider:
name: My Project
orgId: "1234567"
projectId: your-project-id

---

1 change: 1 addition & 0 deletions examples-generated/cloudplatform/project.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ spec:
forProvider:
name: My Project
orgId: "1234567"
projectId: your-project-id

---

1 change: 1 addition & 0 deletions examples/cloudplatform/project.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ metadata:
spec:
forProvider:
projectId: project
name: project

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package/crds/cloudplatform.gcp.upbound.io_projects.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,15 @@ spec:
organization. The numeric ID of the organization this project
belongs to.
type: string
projectId:
description: The project ID. Changing this forces a new project
to be created.
type: string
skipDelete:
type: boolean
required:
- name
- projectId
type: object
providerConfigRef:
default:
Expand Down