Only attempt object scheme parsing if object is not registered in meta #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the package parsing logic to only attempt decoding with the object scheme in the case that the error from decoding in the meta scheme is due to the GVK not being registered. This does not change the definition of a valid package, but does result in more informative errors being returned when a package is invalid due to a malformed meta type. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
negz
approved these changes
Oct 29, 2021
pkg/parser/parser.go
Outdated
| // annotateErr annotates an error if the reader is an AnnotatedReadCloser. | ||
| func annotateErr(err error, reader io.ReadCloser) error { | ||
| if anno, ok := reader.(AnnotatedReadCloser); ok { | ||
| return errors.Wrap(err, fmt.Sprintf("%+v", anno.Annotate())) |
Updates error annotation formatting to use errors.Wrapf. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates the package parsing logic to only attempt decoding with the
object scheme in the case that the error from decoding in the meta
scheme is due to the GVK not being registered. This does not change the
definition of a valid package, but does result in more informative
errors being returned when a package is invalid due to a malformed meta
type.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #299
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested with example in #299 and returned the following error (this is using Crossplane CLI, but same parsing is used in package manager, minus the annotated file position):