Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only attempt object scheme parsing if object is not registered in meta #300

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Only attempt object scheme parsing if object is not registered in meta #300

merged 2 commits into from
Oct 29, 2021

Commits on Oct 29, 2021

  1. Only attempt object scheme parsing if object is not registered in meta 

    Updates the package parsing logic to only attempt decoding with the
object scheme in the case that the error from decoding in the meta
scheme is due to the GVK not being registered. This does not change the
definition of a valid package, but does result in more informative
errors being returned when a package is invalid due to a malformed meta
type.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
    @hasheddan
    hasheddan committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    cc6f044 View commit details
    Browse the repository at this point in the history

  2. Use Wrapf for annotating parser errors 

    Updates error annotation formatting to use errors.Wrapf.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
    @hasheddan
    hasheddan committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    f3ea898 View commit details
    Browse the repository at this point in the history