Tweak ExternalDisconnecter implementation #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary functional change here is to avoid setting a status condition when a deferred disconnect fails. We don't want to overwrite the original status condition that may have been written if we're returning from Reconcile because we hit an error. Emitting an event and a debug log should be sufficient. This commit also tweaks a bit of grammar and updates the NopConnectDisconnecter implementation to more closely match its docstring description. Signed-off-by: Nic Cope <negz@rk0n.org>
negz
commented
Dec 2, 2021
hasheddan
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The primary functional change here is to avoid setting a status condition when a deferred disconnect fails. We don't want to overwrite the original status condition that may have been written if we're returning from Reconcile because we hit an error. Emitting an event and a debug log should be sufficient.
This commit also tweaks a bit of grammar and updates the NopConnectDisconnecter implementation to more closely match its docstring description.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I don't believe there are any consumers of this code yet, so I'm relying on unit tests.