Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak ExternalDisconnecter implementation #306

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Tweak ExternalDisconnecter implementation #306

merged 1 commit into from
Dec 2, 2021

Commits on Dec 2, 2021

  1. Tweak ExternalDisconnecter implementation 

    The primary functional change here is to avoid setting a status condition when a
deferred disconnect fails. We don't want to overwrite the original status
condition that may have been written if we're returning from Reconcile because
we hit an error. Emitting an event and a debug log should be sufficient.

This commit also tweaks a bit of grammar and updates the NopConnectDisconnecter
implementation to more closely match its docstring description.

Signed-off-by: Nic Cope <negz@rk0n.org>
    @negz
    negz committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    295de47 View commit details
    Browse the repository at this point in the history