-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write_cout! fix #212
write_cout! fix #212
Conversation
Or there's 2nd variant of the The 1st variant with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Looks good to me! Still a WIP?
error = Some(Err($crate::ErrorKind::from(e))); | ||
} | ||
_ => {} | ||
if let Err(e) = $command.execute_winapi() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, definately better :)
Yeah, still WIP. Waiting for other PRs to rebase & I didn't go through examples, etc. to check if there is/isn't an unused import. |
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
@TimonPost rebased, added more fixes (see first comment) and finally the whole |
DON'T MERGE as it needs to be rebased after all other PRs will be merged (if they will be) and there will be more occurrences of unusedstd::io::Write
imports.write_cout!
returns number of written bytesTerminal::write
returns number of written bytes (result ofwrite_cout!
)execute!
macro is a bit simplerstd::io::Write
importsNEW
_cursor
&_style
to make thecargo test --all --exclude crossterm_winapi
pass (didn't check_winapi
yet)Fixes #202