Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute all tests on CI + warnings/errors cleanup #216

Merged
merged 19 commits into from
Sep 15, 2019
Merged

Execute all tests on CI + warnings/errors cleanup #216

merged 19 commits into from
Sep 15, 2019

Conversation

zrzka
Copy link
Contributor

@zrzka zrzka commented Sep 14, 2019

Till #215 settles down (GH Actions). It's failing now, because #212 isn't merged yet. Once #212 will be merged, Linux & macOS builds will pass. I'll fix crossterm_winapi issues in another PR and then everything will pass.

Fixes #205

@TimonPost
Copy link
Member

@zrzka
Copy link
Contributor Author

zrzka commented Sep 14, 2019

Going to rebase and will apply #217 changes to this PR, because it's a nightmare to have all these small PRs waiting one for another to pass all the tests.

Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka zrzka changed the title Travis CI - Execute all tests Execute all tests on CI + warnings/errors cleanup Sep 14, 2019
@zrzka
Copy link
Contributor Author

zrzka commented Sep 14, 2019

@TimonPost can you please enable Auto cancel pull request builds?

Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
@TimonPost
Copy link
Member

I checked it, but it is already enabled

Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Copy link
Contributor Author

zrzka commented Sep 14, 2019

Thanks for checking. I had 4 commits in the queue at one time and I thought that this is not enabled. It must have been Travis CI quirk.

@zrzka zrzka changed the title Execute all tests on CI + warnings/errors cleanup [WIP] Execute all tests on CI + warnings/errors cleanup Sep 14, 2019
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
@zrzka
Copy link
Contributor Author

zrzka commented Sep 15, 2019

@TimonPost finally green.

Status

  • Rust stable is passing
  • Rust nightly is passing
    • Was failing on rustfmt, but it's executed on stable only now
  • Zero warnings

Ignored tests & no_run examples

To achieve this, I had to ignore 5 tests and 1 example. All are cursor or resize related, which is expected.

Tests with #[ignore]

  • crossterm_terminal/src/terminal/test.rs - winapi_tests::resize_winapi
  • crossterm_terminal/src/terminal/test.rs - resize_ansi
  • crossterm_winapi/src/console_mode.rs - test::set_get_mode
  • crossterm_cursor/src/cursor/test.rs - reset_safe_ansi
  • crossterm_cursor/src/cursor/test.rs - goto_ansi

Doc examples with no_run

  • crossterm_terminal/src/terminal/terminal.rs - Terminal::exit

Proposal

  • Merge this PR to execute everything on CI
  • Keep the #[ignore] & no_run
    • Already marked with TODOs
    • Create issue for every single ignored test

Anyone can run all (+ ignored) tests by adding --ignored (cargo test):

cargo test --all --exclude crossterm_winapi -- --ignored

At least, this whole PR is a progress in a way that everything is executed on the CI now, it passes and ignored tests can be executed locally till there will be a way to make them passing on CI as well.

@zrzka zrzka changed the title [WIP] Execute all tests on CI + warnings/errors cleanup Execute all tests on CI + warnings/errors cleanup Sep 15, 2019
Signed-off-by: Robert Vojta <rvojta@me.com>
@TimonPost
Copy link
Member

TimonPost commented Sep 15, 2019

Thanks for your contribution!

Sounds like a good idea, resizing caused weird behavior in the terminal as spoken of before. In my opinion, we should just create one issue for all failing tests, just to keep the things together and have less noise in the issue list.

@TimonPost TimonPost merged commit 7cda56b into crossterm-rs:master Sep 15, 2019
@zrzka zrzka deleted the zrzka/travis-ci branch September 16, 2019 05:47
december1981 pushed a commit to december1981/crossterm that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis - Not all tests are executed
2 participants