-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute all tests on CI + warnings/errors cleanup #216
Conversation
Going to rebase and will apply #217 changes to this PR, because it's a nightmare to have all these small PRs waiting one for another to pass all the tests. |
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
@TimonPost can you please enable Auto cancel pull request builds? |
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
I checked it, but it is already enabled |
Signed-off-by: Robert Vojta <rvojta@me.com>
Thanks for checking. I had 4 commits in the queue at one time and I thought that this is not enabled. It must have been Travis CI quirk. |
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
@TimonPost finally green. Status
Ignored tests & no_run examplesTo achieve this, I had to ignore 5 tests and 1 example. All are cursor or resize related, which is expected. Tests with
|
Signed-off-by: Robert Vojta <rvojta@me.com>
Thanks for your contribution! Sounds like a good idea, resizing caused weird behavior in the terminal as spoken of before. In my opinion, we should just create one issue for all failing tests, just to keep the things together and have less noise in the issue list. |
Till #215 settles down (GH Actions). It's failing now, because #212 isn't merged yet. Once #212 will be merged, Linux & macOS builds will pass. I'll fix
crossterm_winapi
issues in another PR and then everything will pass.Fixes #205