Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Simulating events triggers spam-prevention #2672

Open
1 task done
Oceanity opened this issue Aug 7, 2024 · 0 comments
Open
1 task done

[Bug] Simulating events triggers spam-prevention #2672

Oceanity opened this issue Aug 7, 2024 · 0 comments
Assignees
Labels
Bug A defect in the app Dev Approved The issue has been approved by a team member and can be worked on. Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review.

Comments

@Oceanity
Copy link
Contributor

Oceanity commented Aug 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When you Simulate Events with a user account that have a spam-prevention measure like Follow and Raid, those measures are triggered despite it being a test run

Expected Behavior

Simulate Event specifically says it's for testing, and tests should not have lasting changes in the environment they are run in. I had a friend who thought Firebot broke because subsequent tests after the first were silently failing, and I do not believe a user Simulating an Event with a specific username prior to a stream, only to have that same user actually trigger the event and have it fail on them live is expected behavior.

I am aware that Force Event to Run works, but, this does not address the case where an actual Event may silently fail if the user happened to test that Event beforehand with the same username

Steps To Reproduce

  1. Go to Events
  2. Click Simulate Event
  3. Enter a Username
  4. Observe Event fires
  5. Click Simulate Event
  6. Enter same Username
  7. Observe Event silently fails

Version

Firebot: 5.63.0-beta2

What operating system are you using Firebot on?

Windows 10

Relevant log output

No response

Contact Details (Optional)

No response

@Oceanity Oceanity added the Bug A defect in the app label Aug 7, 2024
@ebiggz ebiggz added this to Firebot Aug 19, 2024
@github-project-automation github-project-automation bot moved this to Todo in Firebot Aug 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Work Status Aug 29, 2024
@CaveMobster CaveMobster added the Dev Approved The issue has been approved by a team member and can be worked on. label Feb 21, 2025
@phroggster phroggster self-assigned this Feb 22, 2025
phroggster added a commit to phroggster/Firebot that referenced this issue Feb 22, 2025
- Simulating an event trigger which had caching enabled would inhibit
  later de-factor triggerings of that event, at least until the event
  expired from the cache (12 hrs +/- 10 min).
- Raid, follow, reward redemptions, and viewer arrived events for a
  particular user name would therefore be unusable for 12 hrs.
- Yes, you could force simulate them, but not actually receive them.
- Adjust to having event simulations ignore the cache.
- ref crowbartools#2672, crowbartools#1782
phroggster added a commit to phroggster/Firebot that referenced this issue Feb 22, 2025
- Simulating an event trigger which had caching enabled would inhibit
  later de-facto triggerings of that event, at least until the event
  expired from the cache (12 hrs +/- 10 min).
- Raid, follow, reward redemptions, and viewer arrived events for a
  particular user name would therefore be unusable for 12 hrs.
- Yes, you could force simulate them, but not actually receive them.
- Adjust to having event simulations ignore the cache.
- ref crowbartools#2672, crowbartools#1782
@phroggster phroggster added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app Dev Approved The issue has been approved by a team member and can be worked on. Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review.
Projects
Status: Todo
Status: Backlog
Development

No branches or pull requests

3 participants