fix(events): Don't Cache Simulated Events (#2672) #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b8ef5b4. Signed-off-by: phroggster <phroggster@users.noreply.github.com>
- Simulating an event trigger which had caching enabled would inhibit later de-facto triggerings of that event, at least until the event expired from the cache (12 hrs +/- 10 min). - Raid, follow, reward redemptions, and viewer arrived events for a particular user name would therefore be unusable for 12 hrs. - Yes, you could force simulate them, but not actually receive them. - Adjust to having event simulations ignore the cache. - ref crowbartools#2672, crowbartools#1782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Applicable Issues
#2672
#1782
Testing
Minimal (it works), but I need to submit this first and rouse some troops together for more depth and breadth of testing.Live events and simulated events behave appropriately. Follow/unfollow/follow (and raid) spam hits the caching layer (one event gets through per 12 hrs), before and/or after a simulation with the same data.
Screenshots
New (old) simulate dialog:
Log of simulating two raids from the same user in quick succession:
