Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] support multiple remote-bag-urls. #374

Closed
jasonimercer opened this issue Mar 19, 2020 · 4 comments
Closed

[feature request] support multiple remote-bag-urls. #374

jasonimercer opened this issue Mar 19, 2020 · 4 comments

Comments

@jasonimercer
Copy link

Would it be possible to support multiple remote bags (even 2) in the same way that you support 2 local bags?

Our bagging strategy breaks data into different bags, a "main" bag with most general information and then more customized bags that are useful for triaging specific issues.

Our triage teams have become used to using the webviz links our backend data collector provides, these links bring them to our instance of webviz with a remote-bag-url pointing at a share of the converted data. I would like to be able to offer them links that will present them with simultaneous views into the main bag + the planner image diagnostic bag + a layout url so they're all setup to diagnose whatever they see.

I had a read through the code and I feel like your architecture is very close to already supporting this. There may be issues with multiple data caches? I'm really not sure. If this were a C++ project, I'd be happy to submit an MR but my js skills are classified as "detrimental to the planet".

@jtbandes
Copy link
Contributor

Yes, in fact we are also tracking this request internally. (It's become more relevant in today's work-from-home climate.) I don't want to promise a timeline on behalf of the folks actually working on it, but I think it's likely to be implemented soon, so stay tuned! Thanks for the request!

janpaul123 pushed a commit that referenced this issue Mar 25, 2020
Changelog:
- Added support for streaming a second bag using the `remote-bag-url-2` query parameter in the URL. #374
- Fixed crashing on bags with topics that don't have a message definition. #373
- Fixed not always loading messages when subscribing to a new topic when paused ("backfilling").
- Various performance improvements.
- Improved caching of deserialized messages should result in fewer browser crashes.
- Added `unlimitedMemoryCache` experimental feature to load everything in memory without regard for caching limits. Useful for when you have a machine with lots of memory and you're explicitly OK with Webviz taking up a lot of it. Use at your own risk; this might crash your browser!
- Included an "Add Topics" option for adding markers to the Image panel.
- Made performance improvements to the Plot and State Transitions panels. If you notice any issues, these performance improvements can be disabled in the Experimental Features menu, under "Use a web worker to render the Plot panel".
- In the Image panel, we again filter available marker topics by the namespace of the currently selected camera.
- Added support for publishing messages over the Websocket connection using a Publish panel. #323
@cjds
Copy link

cjds commented Mar 26, 2020

+1 would also love the ability for multiple remote bag URLs. Would even be willing to put my (admittedly limited) TS skills to make it a thing (unless you already have it covered internally)

@jtbandes
Copy link
Contributor

It's already covered in #378!

janpaul123 pushed a commit that referenced this issue Mar 26, 2020
Changelog:
- Added support for streaming a second bag using the `remote-bag-url-2` query parameter in the URL. #374
- Fixed crashing on bags with topics that don't have a message definition. #373
- Various performance improvements.
- Improved caching of deserialized messages should result in fewer browser crashes.
- Added `unlimitedMemoryCache` experimental feature to load everything in memory without regard for caching limits. Useful for when you have a machine with lots of memory and you're explicitly OK with Webviz taking up a lot of it. Use at your own risk; this might crash your browser!
- Included an "Add Topics" option for adding markers to the Image panel.
- Made performance improvements to the Plot and State Transitions panels. If you notice any issues, these performance improvements can be disabled in the Experimental Features menu, under "Use a web worker to render the Plot panel".
- In the Image panel, we again filter available marker topics by the namespace of the currently selected camera.
- Added support for publishing messages over the Websocket connection using a Publish panel. #323
janpaul123 pushed a commit that referenced this issue Apr 9, 2020
Changelog:
- Added support for streaming a second bag using the `remote-bag-url-2` query parameter in the URL. #374
- Fixed crashing on bags with topics that don't have a message definition. #373
- Various performance improvements.
- Improved caching of deserialized messages should result in fewer browser crashes.
- Added `unlimitedMemoryCache` experimental feature to load everything in memory without regard for caching limits. Useful for when you have a machine with lots of memory and you're explicitly OK with Webviz taking up a lot of it. Use at your own risk; this might crash your browser!
- Included an "Add Topics" option for adding markers to the Image panel.
- Made performance improvements to the Plot and State Transitions panels. If you notice any issues, these performance improvements can be disabled in the Experimental Features menu, under "Use a web worker to render the Plot panel".
- In the Image panel, we again filter available marker topics by the namespace of the currently selected camera.
- Added support for publishing messages over the Websocket connection using a Publish panel. #323
- Added layout undo/redo shortcuts.
- Added support for transforms from [`/tf_static`](http://wiki.ros.org/tf2/Tutorials/Writing%20a%20tf2%20static%20broadcaster%20%28C%2B%2B%29). #336
- Deployed a faster format for displaying text in the 3D panel. You can now use `ctrl-f` (or Mac equivalent) to physically move the camera to matched text. If you notice any issues, this change can be disabled in the Experimental Features menu, under "Faster 3D Text".
- Fixed Webviz getting stuck in a reloading loop.
- Added support for streaming a second bag using the `remote-bag-url-2` query parameter in the URL. #374
- Fixed crashing on bags with topics that don't have a message definition. #373
- Fixed not always loading messages when subscribing to a new topic when paused ("backfilling").
- Improved caching of deserialized messages should result in fewer browser crashes.
- Improved startup time by not making multiple requests with different topics when loading the page.
- Fix some cases in which "syncing" 3d panels could cause panels to display a blank screen.
- Fixed not always loading messages when subscribing to a new topic when paused ("backfilling").
- Switched Websocket message encoding to [cbor-raw](RobotWebTools/rosbridge_suite#452). #361
janpaul123 added a commit that referenced this issue Apr 9, 2020
Changelog:
- Added support for streaming a second bag using the `remote-bag-url-2` query parameter in the URL. #374
- Fixed crashing on bags with topics that don't have a message definition. #373
- Various performance improvements.
- Improved caching of deserialized messages should result in fewer browser crashes.
- Added `unlimitedMemoryCache` experimental feature to load everything in memory without regard for caching limits. Useful for when you have a machine with lots of memory and you're explicitly OK with Webviz taking up a lot of it. Use at your own risk; this might crash your browser!
- Included an "Add Topics" option for adding markers to the Image panel.
- Made performance improvements to the Plot and State Transitions panels. If you notice any issues, these performance improvements can be disabled in the Experimental Features menu, under "Use a web worker to render the Plot panel".
- In the Image panel, we again filter available marker topics by the namespace of the currently selected camera.
- Added support for publishing messages over the Websocket connection using a Publish panel. #323
- Added layout undo/redo shortcuts.
- Added support for transforms from [`/tf_static`](http://wiki.ros.org/tf2/Tutorials/Writing%20a%20tf2%20static%20broadcaster%20%28C%2B%2B%29). #336
- Deployed a faster format for displaying text in the 3D panel. You can now use `ctrl-f` (or Mac equivalent) to physically move the camera to matched text. If you notice any issues, this change can be disabled in the Experimental Features menu, under "Faster 3D Text".
- Fixed Webviz getting stuck in a reloading loop.
- Fixed not always loading messages when subscribing to a new topic when paused ("backfilling").
- Improved startup time by not making multiple requests with different topics when loading the page.
- Fix some cases in which "syncing" 3d panels could cause panels to display a blank screen.
- Switched Websocket message encoding to [cbor-raw](RobotWebTools/rosbridge_suite#452). #361
@janpaul123
Copy link
Contributor

This is in the latest release! #396 Thanks for the request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants