Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Subtitles not downloading (One Piece) #297

Closed
sohnemann opened this issue Dec 31, 2023 · 1 comment
Closed

Subtitles not downloading (One Piece) #297

sohnemann opened this issue Dec 31, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@sohnemann
Copy link

Describe the bug
When trying to download any One Piece episode (tried multiple different seasons and episodes), crunchy-cli does not seem to download the subtitles regardless of which language is selected. I have tried all of the following languages, but none of them seem to work:
en-US
de-DE
all

When trying to download darling-in-the-franxx, the subtitles downloaded just fine.

To Reproduce
Steps / command to reproduce the behavior:

$  crunchy-cli archive --audio en-US --subtitle en-US --output "[S{season_number}E{episode_number}] {title}.mkv" https://www.crunchyroll.com/series/GRMG8ZQZR/one-piece\[E1\]                                                                
:: ✔ Logging in
:: ✔ Parsed url 1
Duplicated seasons were found. Select the one you want to download (space to select/deselect; enter to continue):
  [ ] Season 10 (One Piece: Dressrosa (630-699))
  [ ] Season 10 (One Piece: Dressrosa (700-746))
  [ ] Season 11 (One Piece: Silver Mine (747-750))
> [ ] Season 11 (One Piece: Zou (751-782))
:: → Season 7 is only available with en-US audio until episode 516 (Luffy's Training Begins! To the Place We Promised in 2 Years!)
:: → Season 8 is only available with en-US audio until episode 574 (To the New World! Heading for the Ultimate Sea!)
:: → Season 14 is only available with en-US audio until episode 1036 (Fight Against the Dark Night – The Commander-in-chief of the Land of Wano Sounds Off)
:: ✔ Loaded series information for url 1                                                                                                                                                                                                                                                     :: One Piece Season 2 (One Piece: East Blue (1-61) (English Dub))
:: 	1. I’m Luffy! The Man Who’s Gonna Be King of the Pirates! » S02E01
:: Downloading I’m Luffy! The Man Who’s Gonna Be King of the Pirates! to '[S02E01] I’m Luffy! The Man Who’s Gonna Be King of the Pirates!.mkv'
:: 	Episode: S02E01
:: 	Audio: en-US
:: 	Subtitles:
:: 	Resolution: 640x480
:: 	FPS: 23.97

Expected behavior
I expect crunchy-cli to download the subtitles.

Client (please complete the following information):

  • OS: macOS Sonoma 14.2.1
  • Version: crunchy-cli 3.1.1 installed via homebrew

Additional context
Add any other context about the problem here.

@bytedream
Copy link
Member

This issue was due to an api field Crunchyroll only rarely uses and thus, I didn't implemented it. It is now implemented in v3.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants