-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): fix GET /api serialization and webserver JFR event #1193
Conversation
Marked with |
Test image available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
Should there be a test suite for RequestLoggingHandler?
For example testing the basic API specs, and that a WebServerRequest event is really emitted during a handling of some fake RequestHandler perhaps.
5547cc6
to
b396e9e
Compare
Test image available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/main/java/io/cryostat/net/web/http/generic/RequestLoggingHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me :D
Actually... this would end up in the upstream |
a3fd9fb
to
db3cc5b
Compare
Test image available:
|
db3cc5b
to
2d54cd9
Compare
Fixes #1191
Fixes #1192