chore(graphql): cleanup, refactor, async execution

[andrewazores]

Fixes #1201
Related to #1214 / #1193
Depends on cryostatio/cryostat-web#611

[github-actions]

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1202-351a12ae54bd45d6f901102b2aeb2d073b98accb sh smoketest.sh

[github-actions]

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1202-f6ffaedd36f42e5c6ffcd8031bc842fa2b994ed2 sh smoketest.sh

[github-actions]

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1202-2f6d9e3a5f3ecac4c7ab71168ae8c117544bcacb sh smoketest.sh

[maxcao13]

I get

Request failed (500 Internal Server Error)

Internal Server Error caused by JsonParseException: Unrecognized token 'query': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false') at [Source: (io.netty.buffer.ByteBufInputStream); line: 2, column: 13]

When I navigate to the Recording tab.

[andrewazores]

Oh, I guess this does actually need cryostatio/cryostat-web#611 in that case. I worked on them together but it seemed they should work independently. The request being sent has the raw GraphQL query { ... } string as the POST request body, which the handler doesn't seem to know what to do with.

[github-actions]

This PR/issue depends on:

• chore(graphql): add operation names and extract variables cryostat-web#611
  By Dependent Issues (🤖). Happy coding!

[github-actions]

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1202-84b45739a06c04ddea57fa64ab1d824405257b0c sh smoketest.sh

[andrewazores]

Most recent commit touches up the HTTP request logging a little.

INFO: 127.0.0.1 - - [Tue, 8 Nov 2022 00:02:31 GMT] 46ms "GET /api/beta/fs/recordings HTTP/1.1" 200 354 bytes "http://localhost:9000/" "Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Firefox/106.0"

The 46ms is new. Our old custom format built-in to the WebServer class included that detail and it was lost when I switched over to extracting it to a separate Handler and delegating to a Vert.x default implementation. That default implementation also includes the content-length of the response in raw bytes, and I've touched it up to use FileUtils.byteCountToDisplaySize from commons-io so that it's a bit more readable.

[github-actions]

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1202-f16b4d46ffc3ece61ccfceaad65baa974edef4b3 sh smoketest.sh

[github-actions]

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1202-f04d75ef8f1304cf02c1c2777bca982f9e1e733c sh smoketest.sh

[maxcao13]

Everything looks good and graphql does seem to perform better!

[github-actions]

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1202-f993dbafd83fa796bee48af696d24badafbbbf5c sh smoketest.sh