chore(graphql): add operation names and extract variables #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works independently of cryostatio/cryostat#1202 , but that backend PR includes a parsed query caching enhancement that makes the separated query/variables better performing. Without that backend change this doesn't really do much in practical terms. |
andrewazores
force-pushed
the
graphql-variables
branch
from
571d692 to
99908d3
Compare
tthvo
reviewed
Nov 7, 2022
tthvo
reviewed
Nov 7, 2022
There was a problem hiding this comment.
Looks good and worked as expected! Just a question and logs seem to show any logging for requests. Oh nvm, just saw https://github.com/cryostatio/cryostat/pull/1214
tthvo
reviewed
Nov 7, 2022
tthvo
reviewed
Nov 7, 2022
maxcao13
reviewed
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cryostatio/cryostat#1201
See also:
Adding operation names makes it easier to search logs server-side for specific queries for debugging. Extracting variables
allows queries to be reused on the server as explained in links above, which allows query caching for better API performance.