Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): fix "view report" failure timing out on jwt report get handlers #1341

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

maxcao13
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1340

Description of the change:

This change makes some jwt report get handlers non-async. Having them as async was causing a timeout due to the vertx event loop being blocked while waiting for a report response from the reports sidecar.

Motivation for the change:

See #1340
It makes sense that we wouldn't want these handlers async since we are actively waiting on a http response ourselves and are planning to return it.

How to manually test:

  1. Run cryostat normally with smoketest
  2. Create a recording and archive it after a few seconds.
  3. Press view report on the kebab (this uses the jwt handler) (Do not view a report within the iframe as this caches the report).
  4. Notice that the report is generated without a timeout as opposed to before.

Signed-off-by: Max Cao <macao@redhat.com>
@andrewazores
Copy link
Member

Makes sense. itests seem to be flaky failing for unrelated reasons. Will test and verify as soon as images are available.

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1341-266a75d4b48329f53abf5311dc4d3078ba6532fb sh smoketest.sh

@andrewazores andrewazores merged commit 2506522 into cryostatio:main Jan 25, 2023
@maxcao13 maxcao13 deleted the view-report-failure branch January 25, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] "View Report" failure/hang/timeout on archived recordings if not previously generated
2 participants