fix(reports): fix "view report" failure timing out on jwt report get handlers #1341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1340
Description of the change:
This change makes some jwt report get handlers non-async. Having them as
async
was causing a timeout due to the vertx event loop being blocked while waiting for a report response from the reports sidecar.Motivation for the change:
See #1340
It makes sense that we wouldn't want these handlers async since we are actively waiting on a http response ourselves and are planning to return it.
How to manually test: