Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): fix "view report" failure timing out on jwt report get handlers #1341

Merged
merged 2 commits into from
Jan 25, 2023
Merged

fix(reports): fix "view report" failure timing out on jwt report get handlers #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa996e5
fix bug and tests
maxcao13 Jan 25, 2023
266a75d
remove prints
maxcao13 Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/cryostat/net/web/http/api/beta/ReportGetFromPathWithJwtHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public List<HttpMimeType> produces() {

@Override
public boolean isAsync() {
return true;
return false;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/cryostat/net/web/http/api/beta/ReportGetWithJwtHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public List<HttpMimeType> produces() {

@Override
public boolean isAsync() {
return true;
return false;
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/io/cryostat/net/web/http/api/beta/ReportGetFromPathWithJwtHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ void shouldProduceHtmlAndJson() {
}

@Test
void shouldBeAsync() {
Assertions.assertTrue(handler.isAsync());
void shouldNotBeAsync() {
Assertions.assertFalse(handler.isAsync());
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/io/cryostat/net/web/http/api/beta/ReportGetWithJwtHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ void shouldProduceHtmlAndJson() {
}

@Test
void shouldBeAsync() {
Assertions.assertTrue(handler.isAsync());
void shouldNotBeAsync() {
Assertions.assertFalse(handler.isAsync());
}

@Test
Expand Down