Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discovery): internal discovery client for Docker API #1503

Merged
merged 22 commits into from
Jun 12, 2023
Merged

feat(discovery): internal discovery client for Docker API #1503

merged 22 commits into from
Jun 12, 2023

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented May 29, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1439

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label May 29, 2023
@andrewazores andrewazores added feat New feature or request and removed needs-triage Needs thorough attention from code reviewers labels May 29, 2023
This was referenced Jun 1, 2023
Merged
Merged
@mwangggg mwangggg force-pushed the 1439-Docker-API-Discovery branch 2 times, most recently from 6e71a56 to 66ebcf0 Compare June 8, 2023 14:28
@mwangggg mwangggg marked this pull request as ready for review June 8, 2023 14:36
@mwangggg mwangggg force-pushed the 1439-Docker-API-Discovery branch 2 times, most recently from 7c7ba10 to 3e12067 Compare June 8, 2023 15:33
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1503-3e1206754ad4f976a70019451819dc54b35b0965 sh smoketest.sh

@mwangggg mwangggg force-pushed the 1439-Docker-API-Discovery branch from 3e12067 to bae0646 Compare June 8, 2023 20:42
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1503-bae0646264be0d96d0b8eca6240e232c34f8211e sh smoketest.sh

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1503-ae6136348541051cf76f20b444e972f6ef82a2f3 sh smoketest.sh

@mwangggg mwangggg force-pushed the 1439-Docker-API-Discovery branch from ae61363 to 4959a14 Compare June 12, 2023 13:56
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1503-4959a14ce3877a651d70890e9e4667f32a31855f sh smoketest.sh

@andrewazores andrewazores merged commit 916de9f into cryostatio:main Jun 12, 2023
@mwangggg mwangggg deleted the 1439-Docker-API-Discovery branch June 12, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
feat New feature or request safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Story] Docker API discovery
2 participants
@mwangggg @andrewazores