feat(podman): use labels to specify JMX port and optionally host #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependent
needs-triage
andrewazores
added
feat
andrewazores
force-pushed
the
podman-label-discovery
branch
from
fb25cf2 to
8e835ad
Compare
|
This PR/issue depends on:
|
|
Test image available: |
andrewazores
force-pushed
the
podman-label-discovery
branch
from
e28b24b to
a6da5a7
Compare
|
Test image available: |
tthvo
reviewed
Jun 2, 2023
tthvo
reviewed
Jun 2, 2023
tthvo
previously approved these changes
Jun 2, 2023
|
Oh, weird. Not sure why my commits aren't signed. Let me try again. |
andrewazores
force-pushed
the
podman-label-discovery
branch
2 times, most recently
from
3b2dc22 to
1bd08b4
Compare
if hostname is not specified by label then use Podman lookup to determine hostname for container
andrewazores
force-pushed
the
podman-label-discovery
branch
from
1bd08b4 to
28a1513
Compare
tthvo
approved these changes
Jun 2, 2023
|
Test image available: |
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1513
Depends on #1511
Related to #1503
Related to #1394
Description of the change:
This updates the
PodmanPlatformClientto discover target JMX URLs as follows:io.cryostat.discoverylabel, then:io.cryostat.jmxUrllabel. If it is present, use that. Else continue:io.cryostat.jmxPortlabel. If it is present, use this to construct the JMX URL.io.cryostat.jmxHostlabel. If it is not present, default to retrieving the container's hostname from the Podman API. Use this with thejmxPortabove to construct the JMX URL.Since there are now two main routes (
jmxUrl, which replaces the previousconnectUrl, orjmxHost+jmxPort), and the Podman HTTP API does not support querying for containers that have any of a list of labels applied, there is a new required label:io.cryostat.discovery. This label may have any value. This is the label that Cryostat now queries for against the Podman HTTP API to discover containers.Motivation for the change:
As described in #1513, this allows for Podman Discovery to be more flexible and support cases where the container hostname is not known statically when the target application container is started.
How to manually test:
--labels insmoketest.shorrun.shaccording to the description above and ensure they are still picked up after a restart.