chore(recordings): replace subdirectory with jvmId in fromPathHandler #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mwangggg! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
Merged
7 tasks
mwangggg
changed the title
tthvo
reviewed
Oct 2, 2023
There was a problem hiding this comment.
I think there are other places too:
src/main/java/io/cryostat/net/web/http/api/beta/RecordingGetFromPathWithJwtHandler.java:
45
46
47: static final String PATH = "fs/recordings/:subdirectoryName/:recordingName/jwt";
47
48 How about reports endpoints?
src/main/java/io/cryostat/net/web/http/api/beta/ReportGetFromPathHandler.java:
49
50: static final String PATH = "fs/reports/:subdirectoryName/:recordingName";
51
src/main/java/io/cryostat/net/web/http/api/beta/ReportGetFromPathWithJwtHandler.java:
53
54: static final String PATH = "fs/reports/:subdirectoryName/:recordingName/jwt";
55 
|
yea I accidentally marked this as ready-for-review but I still have a bit of work to do oops |
mwangggg
changed the title
|
/request_review |
mwangggg
force-pushed
the
1473-remove-jvmId-recordings
branch
2 times, most recently
from
1a5c989 to
1350d82
Compare
|
/build_test |
|
Needs rebase and |
mwangggg
force-pushed
the
1473-remove-jvmId-recordings
branch
from
1350d82 to
17d2460
Compare
|
/build_test |
|
itest failure, and it looks probably relevant to these changes? |
mwangggg
force-pushed
the
1473-remove-jvmId-recordings
branch
from
e8beed5 to
d7e2bb5
Compare
|
/build_test |
mwangggg
force-pushed
the
1473-remove-jvmId-recordings
branch
from
d7e2bb5 to
0143e0e
Compare
|
/build_test |
|
/build_test |
mwangggg
force-pushed
the
1473-remove-jvmId-recordings
branch
from
e8513e3 to
9f58016
Compare
|
/build_test |
To run smoketest: |
|
/request_review |
andrewazores
approved these changes
Oct 19, 2023
andrewazores
pushed a commit
that referenced
this pull request
Oct 19, 2023
7 tasks
andrewazores
pushed a commit
that referenced
this pull request
Oct 30, 2023
andrewazores
pushed a commit
that referenced
this pull request
Oct 30, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1473
Related to cryostatio/cryostat-web#1126