Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(archives): cannot delete archived recording #176

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #175
Related to https://github.com/cryostatio/cryostat/pull/1692 - -web is shared between the 2.4 and 3.0 server versions, and 2.4/-web expect this API change but 3.0 did not yet.

@andrewazores
Copy link
Member Author

@mwangggg since this relates to your work around jvmIds vs encoded subdirectory names on the 2.4 side, would you mind taking a look around here as well to make sure the 3.0 server matches API for those endpoints?

@andrewazores andrewazores force-pushed the delete-archived-recording branch from 6331935 to 96c4a13 Compare November 21, 2023 19:37
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 11/21/2023, 5:01:19 PM. View Actions Run.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6950023748

1 similar comment
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6950023748

@mwangggg
Copy link
Member

https://github.com/cryostatio/cryostat3/actions/runs/6950023748/job/18909383953#step:13:2896 there are some errors in the tests, but we're being told the tests all pass?

@andrewazores
Copy link
Member Author

#179 ^ ignore JDK 21, it ignores the test failures on purpose for now because they will not work until we upgrade to a much newer Quarkus version.

@andrewazores andrewazores force-pushed the delete-archived-recording branch from d0130fb to 8159c00 Compare November 22, 2023 14:49
@andrewazores andrewazores force-pushed the delete-archived-recording branch from 8159c00 to 1b25136 Compare November 22, 2023 17:49
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@andrewazores andrewazores merged commit 1036a16 into cryostatio:main Nov 22, 2023
7 checks passed
@andrewazores andrewazores deleted the delete-archived-recording branch November 22, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot delete archived recordings
2 participants