-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(archives): cannot delete archived recording #176
fix(archives): cannot delete archived recording #176
Conversation
@mwangggg since this relates to your work around |
6331935
to
96c4a13
Compare
https://github.com/cryostatio/cryostat3/blob/de4db51c85684d81d1fa3562264914ee035da393/src/main/java/io/cryostat/recordings/RecordingHelper.java#L506 I think this function can be removed now |
/build_test |
Workflow started at 11/21/2023, 5:01:19 PM. View Actions Run. |
CI build and push: All tests pass ✅ |
1 similar comment
CI build and push: All tests pass ✅ |
https://github.com/cryostatio/cryostat3/actions/runs/6950023748/job/18909383953#step:13:2896 there are some errors in the tests, but we're being told the tests all pass? |
#179 ^ ignore JDK 21, it ignores the test failures on purpose for now because they will not work until we upgrade to a much newer Quarkus version. |
d0130fb
to
8159c00
Compare
8159c00
to
1b25136
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #175
Related to https://github.com/cryostatio/cryostat/pull/1692 - -web is shared between the 2.4 and 3.0 server versions, and 2.4/-web expect this API change but 3.0 did not yet.