fix(custom-targets): lock form Create button until successful test #1262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1261
Description of the change:
.data.reason
fields. This can happen if the server encounters an unexpected error and responds with an HTTP 500, in which case the response format is not a Cryostat API V2 format but a standard Quarkus 500 format.Motivation for the change:
When creating a custom target the server will already perform a connection test anyway. However, the UI is more informative and makes more sense if the user is first required to perform a successful connection test before they can create the target definition.
How to manually test:
./smoketest.bash -Otr
cryostat3:9091
,localhost:0
,sample-app-1:9093
,reports:11124
,jfr-datasource:11223
,cryostat:9091