Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-targets): lock form Create button until successful test #1262

Merged
merged 2 commits into from
May 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/app/Topology/Actions/CreateTarget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,10 @@ export const CreateTarget: React.FC<CreateTargetProps> = ({ prefilled }) => {
if (option === ValidatedOptions.success) {
exitForm();
} else {
let errorMessage = (body as any)?.data?.reason || 'Connection test failure';
setValidation({
option: option,
errorMessage: body['data']['reason'],
errorMessage,
});
}
}),
Expand Down Expand Up @@ -408,7 +409,7 @@ export const CreateTarget: React.FC<CreateTargetProps> = ({ prefilled }) => {
<ActionGroup>
<Button
variant="primary"
isDisabled={!connectUrl || validConnectUrl !== ValidatedOptions.success || loading || testing}
isDisabled={validation.option !== ValidatedOptions.success}
onClick={handleSubmit}
{...createButtonLoadingProps}
data-quickstart-id="ct-create-btn"
Expand Down
Loading