Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quickstarts): remove outdated feature descriptions #1273

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

andrewazores
Copy link
Member

  • fix(quickstart): rename WebSocket Connection Debouce -> WebSocket retry interval
  • remove explicit versioning, quickstarts correspond to whichever release they are developed with and embedded into
  • remove mention of "View Report" action from recording quickstart
  • remove mention of credentials storage location
  • add note about client-side feature flags

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1265
Fixes: #1266
Fixes: #1267

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewazores andrewazores merged commit 1074c00 into cryostatio:main Jun 7, 2024
24 of 25 checks passed
@andrewazores andrewazores deleted the quickstarts-fixup branch June 7, 2024 21:33
mergify bot pushed a commit that referenced this pull request Jun 7, 2024
* fix(quickstart): rename WebSocket Connection Debouce -> WebSocket retry interval

* remove explicit versioning, quickstarts correspond to whichever release they are developed with and embedded into

* remove mention of "View Report" action from recording quickstart

* remove mention of credentials storage location

* add note about client-side feature flags

(cherry picked from commit 1074c00)
andrewazores added a commit that referenced this pull request Jun 7, 2024
* fix(quickstart): rename WebSocket Connection Debouce -> WebSocket retry interval

* remove explicit versioning, quickstarts correspond to whichever release they are developed with and embedded into

* remove mention of "View Report" action from recording quickstart

* remove mention of credentials storage location

* add note about client-side feature flags

(cherry picked from commit 1074c00)

Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
2 participants