Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(customrecording): disable creation if form invalid/incomplete #253

Merged
merged 2 commits into from
Aug 26, 2021
Merged

fix(customrecording): disable creation if form invalid/incomplete #253

merged 2 commits into from
Aug 26, 2021

Conversation

andrewazores
Copy link
Member

Fixes #252

@ebaron ebaron self-requested a review August 26, 2021 22:06
ebaron
ebaron approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andrewazores andrewazores merged commit 3ae2b0c into cryostatio:main Aug 26, 2021
@andrewazores andrewazores deleted the disable-create-form-submit branch August 26, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom recording "Create" button should be disabled if form is incomplete/invalid
2 participants
@andrewazores @ebaron