Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customrecording): disable creation if form invalid/incomplete #253

Merged
merged 2 commits into from
Aug 26, 2021
+2 −2
Merged

fix(customrecording): disable creation if form invalid/incomplete #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad96f6f
fix(customrecording): disable creation if form invalid/incomplete
andrewazores Aug 26, 2021
278d73e
chore(customrecording): rephrase helper
andrewazores Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/CreateRecording/CustomRecordingForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export const CustomRecordingForm = (props) => {
label="Name"
isRequired
fieldId="recording-name"
helperText="Please enter a recording name, this will be unique within the target JVM"
helperText="Enter a recording name. This will be unique within the target JVM"
validated={nameValid}
>
<TextInput
Expand Down Expand Up @@ -323,7 +323,7 @@ export const CustomRecordingForm = (props) => {
</Form>
</ExpandableSection>
<ActionGroup>
<Button variant="primary" onClick={handleSubmit}>Create</Button>
<Button variant="primary" onClick={handleSubmit} isDisabled={nameValid !== ValidatedOptions.success || !template || !templateType}>Create</Button>
<Button variant="secondary" onClick={history.goBack}>Cancel</Button>
</ActionGroup>
</Form>
Expand Down