This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: rust-secp256k1 fork diverged from upstream #757
Comments
tomtau
changed the title
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Jul 13, 2020
…#757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Jul 14, 2020
…#757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Jul 14, 2020
…#757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Jul 14, 2020
…#757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Jul 14, 2020
…#757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)
tomtau
added a commit
to tomtau/chain
that referenced
this issue
Jul 14, 2020
…#757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)
bors bot
added a commit
that referenced
this issue
Jul 14, 2020
1937: Problem: rust-secp256k1 fork diverged from upstream (fixes #757) r=tomtau a=tomtau Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag) Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
when SchnorrSig + MuSig is merged
bitcoin-core/secp256k1#558
bitcoin-core/secp256k1#588
bitcoin-core/secp256k1#572
bitcoin-core/secp256k1#589
bitcoin-core/secp256k1#590
The text was updated successfully, but these errors were encountered: