This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: rust-secp256k1 fork diverged from upstream (fixes #757) #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
devashishdxt
approved these changes
Jul 13, 2020
tryBuild failed: |
tomtau
force-pushed
the
upstream/secp256k1
branch
2 times, most recently
from
27c360d
to
0b4e8f1
Compare
|
This PR made the following dependency changes: Added Packages (Duplicate versions in '()'):
secp256k1 0.17.2
secp256k1-sys 0.1.3
Removed Packages (Remaining versions in '()'):
secp256k1zkp 0.13.0
|
|
bors try |
tryBuild failed: |
tomtau
force-pushed
the
upstream/secp256k1
branch
from
0b4e8f1
to
063c3a6
Compare
|
bors try |
tryBuild failed: |
tomtau
force-pushed
the
upstream/secp256k1
branch
2 times, most recently
from
de3d723
to
7e11f58
Compare
|
bors retry |
|
bors try |
tryAlready running a review |
tryBuild failed: |
…#757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)
tomtau
force-pushed
the
upstream/secp256k1
branch
from
7e11f58
to
cb5a1d9
Compare
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup
(the vendor script applies custom patches to have mem allocation in Rust etc.)
(one notable change is that signing uses "synthentic nonces"
-- https://moderncrypto.org/mail-archive/curves/2017/000925.html
-- so needs some fresh randomness)
NOTE: MuSig hasn't been ported up to the latest upstream changes yet,
so its related functionality is currently disabled
(when required, it can later be fixed and enabled
via "experimental" feature flag)