Problem: no cluster benchmarking #1431
Conversation
WalkthroughThe recent changes integrate Testground into the project for running benchmarks on a cluster, enhancing testing capabilities. This includes adding new Python modules for context management, networking, synchronization, and peer bootstrapping. Configuration files for Testground, including Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant Testground
participant Context
participant Network
participant SyncService
participant Peer
User->>Testground: Start Benchmark
Testground->>Context: Initialize Context
Context-->>Testground: Context Initialized
Testground->>Network: Retrieve Network IP
Network-->>Testground: IP Addresses
Testground->>SyncService: Establish Sync
SyncService-->>Testground: Sync Established
Testground->>Peer: Bootstrap Peers
Peer-->>Testground: Peers Bootstrapped
Testground->>User: Benchmark Results
Poem
🐇✨ Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
- Integrate testground - Implement python sdk for testground
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
testground/benchmark/flake.lockis excluded by!**/*.locktestground/benchmark/poetry.lockis excluded by!**/*.lock
Files selected for processing (12)
- .gitignore (1 hunks)
- testground/README.md (1 hunks)
- testground/benchmark/benchmark/context.py (1 hunks)
- testground/benchmark/benchmark/main.py (1 hunks)
- testground/benchmark/benchmark/network.py (1 hunks)
- testground/benchmark/benchmark/params.py (1 hunks)
- testground/benchmark/benchmark/sync.py (1 hunks)
- testground/benchmark/benchmark/test_params.py (1 hunks)
- testground/benchmark/benchmark/test_sync.py (1 hunks)
- testground/benchmark/flake.nix (1 hunks)
- testground/benchmark/manifest.toml (1 hunks)
- testground/benchmark/pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (2)
- .gitignore
- testground/benchmark/manifest.toml
Additional Context Used
Ruff (1)
testground/benchmark/benchmark/main.py (1)
1-1:
jsonimported but unused
Markdownlint (6)
testground/README.md (6)
63: Expected: 1; Actual: 2
Multiple consecutive blank lines
26: null
Dollar signs used before commands without showing output
36: null
Dollar signs used before commands without showing output
42: null
Dollar signs used before commands without showing output
50: null
Dollar signs used before commands without showing output
41: null
Fenced code blocks should have a language specified
GitHub Check Runs (1)
Lint python failure (3)
testground/benchmark/benchmark/main.py: [failure] 1-1:
./testground/benchmark/benchmark/main.py:1:1: F401 'json' imported but unused
Additional comments not posted (17)
testground/benchmark/pyproject.toml (1)
1-22: Configuration inpyproject.tomllooks correct and well-structured.testground/benchmark/benchmark/network.py (1)
9-26: Network functions are implemented correctly and use appropriate libraries for handling IP addresses.testground/benchmark/benchmark/main.py (1)
9-44: Main execution logic and entry point are correctly implemented.testground/benchmark/benchmark/test_sync.py (1)
1-48: Synchronization tests are implemented correctly and cover necessary scenarios.testground/benchmark/benchmark/test_params.py (1)
1-47: Test forRunParamsis correctly implemented and covers all necessary attributes.testground/benchmark/benchmark/context.py (7)
8-12: Initialization method correctly handles default parameters.
14-27: Effective orchestration of initialization steps using asynchronous patterns.
28-36: Clear use of conditional logic to handle network readiness based on configuration.
38-53: Defensive programming correctly applied to handle optional network configuration.
54-71: Correct implementation of event signaling for success and failure scenarios.
73-91: Simplicity and effective use ofSyncServicein stage management.
93-97: Proper implementation of the context manager protocol ensures resource management.testground/benchmark/flake.nix (1)
1-91: Nix flake configuration correctly sets up dependencies and build instructions.testground/benchmark/benchmark/params.py (2)
7-26: Data class correctly uses modern Python features and best practices for clarity and error prevention.
88-103: Robust handling of environment variables to dynamically createRunParamsinstances.testground/benchmark/benchmark/sync.py (2)
14-160: Appropriate use of websockets and threading for real-time communication in a distributed environment.
168-185: Correct use of threading constructs to manage synchronization effectively.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- testground/benchmark/benchmark/main.py (1 hunks)
- testground/benchmark/benchmark/sync.py (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- testground/benchmark/benchmark/main.py
- testground/benchmark/benchmark/sync.py
|
do we need .env.toml for benchmark? |
not for |
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
testground/README.md (1)
Line range hint
64-64: Remove extra blank line for consistency.- 63~ -
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
testground/benchmark/poetry.lockis excluded by!**/*.lock
Files selected for processing (10)
- testground/README.md (1 hunks)
- testground/benchmark/benchmark/context.py (1 hunks)
- testground/benchmark/benchmark/main.py (1 hunks)
- testground/benchmark/benchmark/params.py (1 hunks)
- testground/benchmark/benchmark/peer.py (1 hunks)
- testground/benchmark/benchmark/sync.py (1 hunks)
- testground/benchmark/benchmark/test_params.py (1 hunks)
- testground/benchmark/compositions/local.toml (1 hunks)
- testground/benchmark/manifest.toml (1 hunks)
- testground/benchmark/pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (1)
- testground/benchmark/compositions/local.toml
Files skipped from review as they are similar to previous changes (7)
- testground/benchmark/benchmark/context.py
- testground/benchmark/benchmark/main.py
- testground/benchmark/benchmark/params.py
- testground/benchmark/benchmark/sync.py
- testground/benchmark/benchmark/test_params.py
- testground/benchmark/manifest.toml
- testground/benchmark/pyproject.toml
Additional Context Used
Markdownlint (7)
testground/README.md (7)
64: Expected: 1; Actual: 2
Multiple consecutive blank lines
26: null
Dollar signs used before commands without showing output
36: null
Dollar signs used before commands without showing output
42: null
Dollar signs used before commands without showing output
43: null
Dollar signs used before commands without showing output
51: null
Dollar signs used before commands without showing output
41: null
Fenced code blocks should have a language specified
Additional comments not posted (2)
testground/benchmark/benchmark/peer.py (2)
83-102: Consider refactoringgentxto separate concerns between transaction creation and JSON handling.
[REFACTOR_SUGGESTion]- def gentx(cli, chain_id): - cli( - "genesis", - "add-genesis-account", - "validator", - INITIAL_AMOUNT, - keyring_backend="test", - ) - output = Path("gentx.json") - cli( - "genesis", - "gentx", - "validator", - STAKED_AMOUNT, - min_self_delegation=1, - chain_id=chain_id, - output_document=output, - keyring_backend="test", - ) - return json.loads(output.read_text()) + def create_genesis_transaction(cli, chain_id): + cli("genesis", "add-genesis-account", "validator", INITIAL_AMOUNT, keyring_backend="test") + output = Path("gentx.json") + cli("genesis", "gentx", "validator", STAKED_AMOUNT, min_self_delegation=1, chain_id=chain_id, output_document=output, keyring_backend="test") + return output + + def read_transaction(output_path): + return json.loads(output_path.read_text())
29-80: Ensure proper error handling in thebootstrapfunction.
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- testground/benchmark/benchmark/main.py (1 hunks)
- testground/benchmark/benchmark/peer.py (1 hunks)
- testground/benchmark/benchmark/topology.py (1 hunks)
- testground/benchmark/benchmark/types.py (1 hunks)
- testground/benchmark/benchmark/utils.py (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- testground/benchmark/benchmark/main.py
- testground/benchmark/benchmark/peer.py
Additional comments not posted (3)
testground/benchmark/benchmark/types.py (2)
6-8: LGTM! TheGenesisAccountclass is well-defined with appropriate types for blockchain data.
11-16: LGTM! ThePeerPacketclass is appropriately structured for networking purposes, with an optionalgentxfield correctly implemented.testground/benchmark/benchmark/topology.py (1)
6-12: LGTM! Theconnect_allfunction is correctly implemented to exclude the peer's own ID, which is crucial for peer-to-peer network configurations.
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
testground/benchmark/poetry.lockis excluded by!**/*.lock
Files selected for processing (6)
- testground/benchmark/benchmark/cli.py (1 hunks)
- testground/benchmark/benchmark/main.py (1 hunks)
- testground/benchmark/benchmark/params.py (1 hunks)
- testground/benchmark/benchmark/peer.py (1 hunks)
- testground/benchmark/benchmark/utils.py (1 hunks)
- testground/benchmark/pyproject.toml (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- testground/benchmark/benchmark/main.py
- testground/benchmark/benchmark/params.py
- testground/benchmark/benchmark/utils.py
- testground/benchmark/pyproject.toml
Additional comments not posted (5)
testground/benchmark/benchmark/cli.py (3)
5-19: TheChainCommandclass implementation looks robust and secure. Consider adding a docstring to the class for better clarity and documentation.
38-45: The implementation ofbuild_cli_args_safeeffectively mitigates risks of command injection by sanitizing inputs. Well done!
48-52: Thesafe_cli_stringfunction correctly handles CLI arguments that contain spaces by wrapping them in quotes. This is a good security practice.testground/benchmark/benchmark/peer.py (2)
93-112: Thegentxfunction securely handles file operations and CLI interactions. Good job ensuring that the output is properly managed and parsed.
115-125: Thecollect_gen_txfunction correctly uses a temporary directory for handling file operations, which is a secure practice. Well implemented!
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (1)
testground/benchmark/benchmark/sendtx.py (1)
19-19: Consider parameterizing the hardcoded recipient address.Using a hardcoded address can limit flexibility and maintainability. Consider passing it as a function parameter or defining it as a global constant if it doesn't change.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
testground/benchmark/flake.lockis excluded by!**/*.locktestground/benchmark/poetry.lockis excluded by!**/*.lock
Files selected for processing (9)
- testground/benchmark/benchmark/main.py (1 hunks)
- testground/benchmark/benchmark/params.py (1 hunks)
- testground/benchmark/benchmark/peer.py (1 hunks)
- testground/benchmark/benchmark/sendtx.py (1 hunks)
- testground/benchmark/benchmark/types.py (1 hunks)
- testground/benchmark/benchmark/utils.py (1 hunks)
- testground/benchmark/compositions/local.toml (1 hunks)
- testground/benchmark/flake.nix (1 hunks)
- testground/benchmark/pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (1)
- testground/benchmark/pyproject.toml
Files skipped from review as they are similar to previous changes (5)
- testground/benchmark/benchmark/main.py
- testground/benchmark/benchmark/params.py
- testground/benchmark/benchmark/peer.py
- testground/benchmark/benchmark/types.py
- testground/benchmark/compositions/local.toml
Additional comments not posted (11)
testground/benchmark/benchmark/sendtx.py (2)
27-31: Ensure robust handling of nonce errors.The current handling of "invalid nonce" errors by resetting the nonce is a good start, but consider adding logging for such events to aid in debugging and monitoring.
34-34: Verify the final nonce check.Verification successful
The final nonce check in the code is correctly implemented. The
export_eth_accountfunction returns anAccountobject, and the nonce check compares the nonce obtained from the blockchain with the expected nonce.
- The
export_eth_accountfunction is defined intestground/benchmark/benchmark/sendtx.pyand returns anAccountobject created from a key exported by theclicommand.- The nonce check in the test file correctly compares the nonce obtained from the blockchain with the expected nonce.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the nonce calculation aligns with the transaction count in the blockchain. # Test: Check the blockchain directly for the transaction count. echo "Check the blockchain for the transaction count at the address."Length of output: 134
Script:
#!/bin/bash # Extract the account address used in the test file fd sendtx.py | xargs grep -Po 'acct\.address\s*=\s*"\K[^"]+'Length of output: 62
Script:
#!/bin/bash # Fetch the nonce from the blockchain for the extracted account address ACCOUNT_ADDRESS=$(fd sendtx.py | xargs grep -Po 'acct\.address\s*=\s*"\K[^"]+') w3=$(python3 -c "from web3 import Web3; print(Web3(Web3.HTTPProvider('http://localhost:8545')))") NONCE=$(python3 -c "print($w3.eth.get_transaction_count('$ACCOUNT_ADDRESS'))") echo "Nonce from blockchain: $NONCE"Length of output: 466
Script:
#!/bin/bash # Inspect the test file for the account address pattern fd sendtx.py | xargs grep -E 'acct\.address\s*='Length of output: 50
Script:
#!/bin/bash # Ensure Python and Web3 are available and fetch the nonce from the blockchain for the extracted account address ACCOUNT_ADDRESS=$(fd sendtx.py | xargs grep -Po 'acct\.address\s*=\s*"\K[^"]+') if [ -z "$ACCOUNT_ADDRESS" ]; then echo "Account address not found in the test file." exit 1 fi # Check if Python is installed if ! command -v python3 &> /dev/null; then echo "Python3 is not installed." exit 1 fi # Check if Web3 is installed if ! python3 -c "import web3" &> /dev/null; then echo "Web3 is not installed." exit 1 fi w3=$(python3 -c "from web3 import Web3; print(Web3(Web3.HTTPProvider('http://localhost:8545')))") NONCE=$(python3 -c "print($w3.eth.get_transaction_count('$ACCOUNT_ADDRESS'))") echo "Nonce from blockchain: $NONCE"Length of output: 205
Script:
#!/bin/bash # Search for any occurrence of 'acct' in the test file to understand its context and definition fd sendtx.py | xargs grep -E 'acct'Length of output: 406
Script:
#!/bin/bash # Extract the account address from the export_eth_account function call fd sendtx.py | xargs grep -Po 'export_eth_account\([^,]+, "\K[^"]+'Length of output: 77
Script:
#!/bin/bash # Search for the implementation of the export_eth_account function ast-grep --lang python --pattern 'def export_eth_account($_, $_):'Length of output: 68
Script:
#!/bin/bash # Search for the definition of the export_eth_account function in the entire codebase rg 'def export_eth_account'Length of output: 121
Script:
#!/bin/bash # Extract the implementation of the export_eth_account function from the sendtx.py file ast-grep --lang python --pattern 'def export_eth_account($_, $_):' testground/benchmark/benchmark/sendtx.pyLength of output: 109
Script:
#!/bin/bash # Search for the definition of the export_eth_account function in the sendtx.py file rg 'def export_eth_account' testground/benchmark/benchmark/sendtx.pyLength of output: 121
Script:
#!/bin/bash # Extract the full implementation of the export_eth_account function from the sendtx.py file sed -n '/def export_eth_account/,/^$/p' testground/benchmark/benchmark/sendtx.pyLength of output: 243
testground/benchmark/benchmark/utils.py (8)
22-26: Functionpatch_tomlcorrectly handles reading, updating, and writing TOML files.
29-33: Functionpatch_jsoncorrectly handles reading, updating, and writing JSON files.
36-48: Functionwait_for_portcorrectly implements a timeout mechanism for network operations.
51-65: Functionwait_for_blockcorrectly implements a timeout mechanism for blockchain operations.
70-72: Functiondecode_bech32correctly decodes Bech32 addresses.
75-76: Functionbech32_to_ethcorrectly converts Bech32 addresses to Ethereum addresses.
79-84: Functionsign_transactioncorrectly handles transaction signing.
87-92: Functionsend_transactioncorrectly handles transaction sending and receipt waiting.testground/benchmark/flake.nix (1)
1-93: Review the entireflake.nixconfiguration.The Nix flake configuration appears comprehensive, but ensure all dependencies and configurations are correctly specified and that there are no missing or redundant entries.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- testground/benchmark/benchmark/sendtx.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- testground/benchmark/benchmark/sendtx.py
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
testground/README.md (1)
Line range hint
63-63: Remove extra blank lines for better readability.- -
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
testground/benchmark/flake.lockis excluded by!**/*.locktestground/benchmark/poetry.lockis excluded by!**/*.lock
Files selected for processing (3)
- testground/README.md (1 hunks)
- testground/benchmark/compositions/local.toml (1 hunks)
- testground/benchmark/pyproject.toml (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- testground/benchmark/compositions/local.toml
- testground/benchmark/pyproject.toml
Additional Context Used
Markdownlint (5)
testground/README.md (5)
63: Expected: 1; Actual: 2
Multiple consecutive blank lines
26: null
Dollar signs used before commands without showing output
36: null
Dollar signs used before commands without showing output
42: null
Dollar signs used before commands without showing output
50: null
Dollar signs used before commands without showing output
Additional comments not posted (5)
testground/README.md (5)
9-11: Prerequisites are clearly listed and appropriate.
14-19: Installation instructions are clear and concise.
26-27: Ensure to keep the Testground daemon running during tests.
36-43: Instructions for running the test plan are detailed and helpful.
47-61: macOS specific instructions are well-detailed and considerate of user needs.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...
[misspelling] ~124-~124: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives.
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...
[style] ~165-~165: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...
[style] ~166-~166: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...
[style] ~167-~167: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...
[style] ~168-~168: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...
[style] ~169-~169: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...
[style] ~170-~170: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...
[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...
[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...
[style] ~175-~175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...
[style] ~176-~176: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...
[style] ~177-~177: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ov1.10.26and ibc-go tov6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...
[style] ~181-~181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...
[style] ~182-~182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...
[style] ~183-~183: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...
[style] ~184-~184: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ull/1184) Update ibc-go tov7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...
[style] ~185-~185: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...
[style] ~186-~186: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...
[style] ~187-~187: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...
[grammar] ~206-~206: It seems that “to” is missing before the verb.
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...
[misspelling] ~210-~210: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...
[grammar] ~326-~326: After ‘it’, use the third-person verb form “fixes”.
Context: ...790) Update cosmos-sdk tov0.46.7, it fix a migration issue which affects pending...
[style] ~393-~393: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...
[style] ~415-~415: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...
[style] ~416-~416: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...
[style] ~417-~417: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...
[style] ~432-~432: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...
[style] ~433-~433: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...
[style] ~434-~434: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...
[style] ~452-~452: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...
[style] ~453-~453: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...
[style] ~454-~454: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...
[style] ~455-~455: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...
[style] ~461-~461: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...
[style] ~462-~462: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...
[style] ~476-~476: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...
[style] ~477-~477: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...
[style] ~480-~480: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...
[style] ~488-~488: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...
[style] ~489-~489: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...query result when--traceenabled. - [cronos#441](https://github.com/crypto-org-chai...
[style] ~496-~496: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....
[style] ~497-~497: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...
[style] ~498-~498: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t, b) fix data racestraceContext. - [cronos#370](https://github.com/crypto-org-chai...
[style] ~499-~499: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...
[style] ~500-~500: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...
[grammar] ~620-~620: After ‘it’, use the third-person verb form “upgrades”.
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...
[uncategorized] ~658-~658: Possible missing comma found.
Context: ... version is a new scaffolding of cronos project where ethermint is included as a librar...
Markdownlint
CHANGELOG.md
48-48: Expected: asterisk; Actual: dash
Unordered list style
60-60: Expected: asterisk; Actual: dash
Unordered list style
68-68: Expected: asterisk; Actual: dash
Unordered list style
76-76: Expected: asterisk; Actual: dash
Unordered list style
84-84: Expected: asterisk; Actual: dash
Unordered list style
85-85: Expected: asterisk; Actual: dash
Unordered list style
86-86: Expected: asterisk; Actual: dash
Unordered list style
90-90: Expected: asterisk; Actual: dash
Unordered list style
98-98: Expected: asterisk; Actual: dash
Unordered list style
99-99: Expected: asterisk; Actual: dash
Unordered list style
100-100: Expected: asterisk; Actual: dash
Unordered list style
101-101: Expected: asterisk; Actual: dash
Unordered list style
102-102: Expected: asterisk; Actual: dash
Unordered list style
103-103: Expected: asterisk; Actual: dash
Unordered list style
107-107: Expected: asterisk; Actual: dash
Unordered list style
108-108: Expected: asterisk; Actual: dash
Unordered list style
114-114: Expected: asterisk; Actual: dash
Unordered list style
115-115: Expected: asterisk; Actual: dash
Unordered list style
116-116: Expected: asterisk; Actual: dash
Unordered list style
117-117: Expected: asterisk; Actual: dash
Unordered list style
118-118: Expected: asterisk; Actual: dash
Unordered list style
122-122: Expected: asterisk; Actual: dash
Unordered list style
123-123: Expected: asterisk; Actual: dash
Unordered list style
124-124: Expected: asterisk; Actual: dash
Unordered list style
125-125: Expected: asterisk; Actual: dash
Unordered list style
126-126: Expected: asterisk; Actual: dash
Unordered list style
127-127: Expected: asterisk; Actual: dash
Unordered list style
131-131: Expected: asterisk; Actual: dash
Unordered list style
132-132: Expected: asterisk; Actual: dash
Unordered list style
133-133: Expected: asterisk; Actual: dash
Unordered list style
134-134: Expected: asterisk; Actual: dash
Unordered list style
135-135: Expected: asterisk; Actual: dash
Unordered list style
136-136: Expected: asterisk; Actual: dash
Unordered list style
140-140: Expected: asterisk; Actual: dash
Unordered list style
141-141: Expected: asterisk; Actual: dash
Unordered list style
142-142: Expected: asterisk; Actual: dash
Unordered list style
150-150: Expected: asterisk; Actual: dash
Unordered list style
151-151: Expected: asterisk; Actual: dash
Unordered list style
155-155: Expected: asterisk; Actual: dash
Unordered list style
163-163: Expected: asterisk; Actual: dash
Unordered list style
164-164: Expected: asterisk; Actual: dash
Unordered list style
165-165: Expected: asterisk; Actual: dash
Unordered list style
166-166: Expected: asterisk; Actual: dash
Unordered list style
167-167: Expected: asterisk; Actual: dash
Unordered list style
168-168: Expected: asterisk; Actual: dash
Unordered list style
169-169: Expected: asterisk; Actual: dash
Unordered list style
170-170: Expected: asterisk; Actual: dash
Unordered list style
171-171: Expected: asterisk; Actual: dash
Unordered list style
172-172: Expected: asterisk; Actual: dash
Unordered list style
173-173: Expected: asterisk; Actual: dash
Unordered list style
174-174: Expected: asterisk; Actual: dash
Unordered list style
175-175: Expected: asterisk; Actual: dash
Unordered list style
176-176: Expected: asterisk; Actual: dash
Unordered list style
177-177: Expected: asterisk; Actual: dash
Unordered list style
178-178: Expected: asterisk; Actual: dash
Unordered list style
179-179: Expected: asterisk; Actual: dash
Unordered list style
180-180: Expected: asterisk; Actual: dash
Unordered list style
181-181: Expected: asterisk; Actual: dash
Unordered list style
182-182: Expected: asterisk; Actual: dash
Unordered list style
183-183: Expected: asterisk; Actual: dash
Unordered list style
184-184: Expected: asterisk; Actual: dash
Unordered list style
185-185: Expected: asterisk; Actual: dash
Unordered list style
186-186: Expected: asterisk; Actual: dash
Unordered list style
187-187: Expected: asterisk; Actual: dash
Unordered list style
191-191: Expected: asterisk; Actual: dash
Unordered list style
192-192: Expected: asterisk; Actual: dash
Unordered list style
193-193: Expected: asterisk; Actual: dash
Unordered list style
194-194: Expected: asterisk; Actual: dash
Unordered list style
195-195: Expected: asterisk; Actual: dash
Unordered list style
196-196: Expected: asterisk; Actual: dash
Unordered list style
197-197: Expected: asterisk; Actual: dash
Unordered list style
198-198: Expected: asterisk; Actual: dash
Unordered list style
199-199: Expected: asterisk; Actual: dash
Unordered list style
200-200: Expected: asterisk; Actual: dash
Unordered list style
201-201: Expected: asterisk; Actual: dash
Unordered list style
202-202: Expected: asterisk; Actual: dash
Unordered list style
203-203: Expected: asterisk; Actual: dash
Unordered list style
204-204: Expected: asterisk; Actual: dash
Unordered list style
205-205: Expected: asterisk; Actual: dash
Unordered list style
206-206: Expected: asterisk; Actual: dash
Unordered list style
210-210: Expected: asterisk; Actual: dash
Unordered list style
211-211: Expected: asterisk; Actual: dash
Unordered list style
212-212: Expected: asterisk; Actual: dash
Unordered list style
213-213: Expected: asterisk; Actual: dash
Unordered list style
214-214: Expected: asterisk; Actual: dash
Unordered list style
215-215: Expected: asterisk; Actual: dash
Unordered list style
216-216: Expected: asterisk; Actual: dash
Unordered list style
217-217: Expected: asterisk; Actual: dash
Unordered list style
221-221: Expected: asterisk; Actual: dash
Unordered list style
222-222: Expected: asterisk; Actual: dash
Unordered list style
223-223: Expected: asterisk; Actual: dash
Unordered list style
224-224: Expected: asterisk; Actual: dash
Unordered list style
225-225: Expected: asterisk; Actual: dash
Unordered list style
226-226: Expected: asterisk; Actual: dash
Unordered list style
227-227: Expected: asterisk; Actual: dash
Unordered list style
228-228: Expected: asterisk; Actual: dash
Unordered list style
229-229: Expected: asterisk; Actual: dash
Unordered list style
230-230: Expected: asterisk; Actual: dash
Unordered list style
231-231: Expected: asterisk; Actual: dash
Unordered list style
232-232: Expected: asterisk; Actual: dash
Unordered list style
233-233: Expected: asterisk; Actual: dash
Unordered list style
234-234: Expected: asterisk; Actual: dash
Unordered list style
235-235: Expected: asterisk; Actual: dash
Unordered list style
236-236: Expected: asterisk; Actual: dash
Unordered list style
237-237: Expected: asterisk; Actual: dash
Unordered list style
238-238: Expected: asterisk; Actual: dash
Unordered list style
239-239: Expected: asterisk; Actual: dash
Unordered list style
240-240: Expected: asterisk; Actual: dash
Unordered list style
241-241: Expected: asterisk; Actual: dash
Unordered list style
242-242: Expected: asterisk; Actual: dash
Unordered list style
243-243: Expected: asterisk; Actual: dash
Unordered list style
244-244: Expected: asterisk; Actual: dash
Unordered list style
245-245: Expected: asterisk; Actual: dash
Unordered list style
253-253: Expected: asterisk; Actual: dash
Unordered list style
254-254: Expected: asterisk; Actual: dash
Unordered list style
255-255: Expected: asterisk; Actual: dash
Unordered list style
259-259: Expected: asterisk; Actual: dash
Unordered list style
260-260: Expected: asterisk; Actual: dash
Unordered list style
261-261: Expected: asterisk; Actual: dash
Unordered list style
262-262: Expected: asterisk; Actual: dash
Unordered list style
263-263: Expected: asterisk; Actual: dash
Unordered list style
264-264: Expected: asterisk; Actual: dash
Unordered list style
265-265: Expected: asterisk; Actual: dash
Unordered list style
273-273: Expected: asterisk; Actual: dash
Unordered list style
281-281: Expected: asterisk; Actual: dash
Unordered list style
285-285: Expected: asterisk; Actual: dash
Unordered list style
286-286: Expected: asterisk; Actual: dash
Unordered list style
287-287: Expected: asterisk; Actual: dash
Unordered list style
295-295: Expected: asterisk; Actual: dash
Unordered list style
299-299: Expected: asterisk; Actual: dash
Unordered list style
300-300: Expected: asterisk; Actual: dash
Unordered list style
301-301: Expected: asterisk; Actual: dash
Unordered list style
309-309: Expected: asterisk; Actual: dash
Unordered list style
317-317: Expected: asterisk; Actual: dash
Unordered list style
325-325: Expected: asterisk; Actual: dash
Unordered list style
326-326: Expected: asterisk; Actual: dash
Unordered list style
335-335: Expected: asterisk; Actual: dash
Unordered list style
343-343: Expected: asterisk; Actual: dash
Unordered list style
351-351: Expected: asterisk; Actual: dash
Unordered list style
359-359: Expected: asterisk; Actual: dash
Unordered list style
360-360: Expected: asterisk; Actual: dash
Unordered list style
361-361: Expected: asterisk; Actual: dash
Unordered list style
362-362: Expected: asterisk; Actual: dash
Unordered list style
370-370: Expected: asterisk; Actual: dash
Unordered list style
378-378: Expected: asterisk; Actual: dash
Unordered list style
379-379: Expected: asterisk; Actual: dash
Unordered list style
387-387: Expected: asterisk; Actual: dash
Unordered list style
391-391: Expected: asterisk; Actual: dash
Unordered list style
392-392: Expected: asterisk; Actual: dash
Unordered list style
393-393: Expected: asterisk; Actual: dash
Unordered list style
401-401: Expected: asterisk; Actual: dash
Unordered list style
413-413: Expected: asterisk; Actual: dash
Unordered list style
414-414: Expected: asterisk; Actual: dash
Unordered list style
415-415: Expected: asterisk; Actual: dash
Unordered list style
416-416: Expected: asterisk; Actual: dash
Unordered list style
417-417: Expected: asterisk; Actual: dash
Unordered list style
418-418: Expected: asterisk; Actual: dash
Unordered list style
419-419: Expected: asterisk; Actual: dash
Unordered list style
423-423: Expected: asterisk; Actual: dash
Unordered list style
424-424: Expected: asterisk; Actual: dash
Unordered list style
425-425: Expected: asterisk; Actual: dash
Unordered list style
429-429: Expected: asterisk; Actual: dash
Unordered list style
430-430: Expected: asterisk; Actual: dash
Unordered list style
431-431: Expected: asterisk; Actual: dash
Unordered list style
432-432: Expected: asterisk; Actual: dash
Unordered list style
433-433: Expected: asterisk; Actual: dash
Unordered list style
434-434: Expected: asterisk; Actual: dash
Unordered list style
442-442: Expected: asterisk; Actual: dash
Unordered list style
450-450: Expected: asterisk; Actual: dash
Unordered list style
451-451: Expected: asterisk; Actual: dash
Unordered list style
452-452: Expected: asterisk; Actual: dash
Unordered list style
453-453: Expected: asterisk; Actual: dash
Unordered list style
454-454: Expected: asterisk; Actual: dash
Unordered list style
455-455: Expected: asterisk; Actual: dash
Unordered list style
459-459: Expected: asterisk; Actual: dash
Unordered list style
460-460: Expected: asterisk; Actual: dash
Unordered list style
461-461: Expected: asterisk; Actual: dash
Unordered list style
462-462: Expected: asterisk; Actual: dash
Unordered list style
470-470: Expected: asterisk; Actual: dash
Unordered list style
471-471: Expected: asterisk; Actual: dash
Unordered list style
472-472: Expected: asterisk; Actual: dash
Unordered list style
473-473: Expected: asterisk; Actual: dash
Unordered list style
474-474: Expected: asterisk; Actual: dash
Unordered list style
475-475: Expected: asterisk; Actual: dash
Unordered list style
476-476: Expected: asterisk; Actual: dash
Unordered list style
477-477: Expected: asterisk; Actual: dash
Unordered list style
478-478: Expected: asterisk; Actual: dash
Unordered list style
479-479: Expected: asterisk; Actual: dash
Unordered list style
480-480: Expected: asterisk; Actual: dash
Unordered list style
481-481: Expected: asterisk; Actual: dash
Unordered list style
485-485: Expected: asterisk; Actual: dash
Unordered list style
486-486: Expected: asterisk; Actual: dash
Unordered list style
487-487: Expected: asterisk; Actual: dash
Unordered list style
488-488: Expected: asterisk; Actual: dash
Unordered list style
489-489: Expected: asterisk; Actual: dash
Unordered list style
493-493: Expected: asterisk; Actual: dash
Unordered list style
494-494: Expected: asterisk; Actual: dash
Unordered list style
495-495: Expected: asterisk; Actual: dash
Unordered list style
496-496: Expected: asterisk; Actual: dash
Unordered list style
497-497: Expected: asterisk; Actual: dash
Unordered list style
498-498: Expected: asterisk; Actual: dash
Unordered list style
499-499: Expected: asterisk; Actual: dash
Unordered list style
500-500: Expected: asterisk; Actual: dash
Unordered list style
508-508: Expected: asterisk; Actual: dash
Unordered list style
509-509: Expected: asterisk; Actual: dash
Unordered list style
517-517: Expected: asterisk; Actual: dash
Unordered list style
525-525: Expected: asterisk; Actual: dash
Unordered list style
526-526: Expected: asterisk; Actual: dash
Unordered list style
527-527: Expected: asterisk; Actual: dash
Unordered list style
531-531: Expected: asterisk; Actual: dash
Unordered list style
532-532: Expected: asterisk; Actual: dash
Unordered list style
540-540: Expected: asterisk; Actual: dash
Unordered list style
541-541: Expected: asterisk; Actual: dash
Unordered list style
542-542: Expected: asterisk; Actual: dash
Unordered list style
543-543: Expected: asterisk; Actual: dash
Unordered list style
544-544: Expected: asterisk; Actual: dash
Unordered list style
552-552: Expected: asterisk; Actual: dash
Unordered list style
556-556: Expected: asterisk; Actual: dash
Unordered list style
557-557: Expected: asterisk; Actual: dash
Unordered list style
558-558: Expected: asterisk; Actual: dash
Unordered list style
559-559: Expected: asterisk; Actual: dash
Unordered list style
569-569: Expected: asterisk; Actual: dash
Unordered list style
573-573: Expected: asterisk; Actual: dash
Unordered list style
574-574: Expected: asterisk; Actual: dash
Unordered list style
575-575: Expected: asterisk; Actual: dash
Unordered list style
576-576: Expected: asterisk; Actual: dash
Unordered list style
580-580: Expected: asterisk; Actual: dash
Unordered list style
581-581: Expected: asterisk; Actual: dash
Unordered list style
592-592: Expected: asterisk; Actual: dash
Unordered list style
593-593: Expected: asterisk; Actual: dash
Unordered list style
594-594: Expected: asterisk; Actual: dash
Unordered list style
595-595: Expected: asterisk; Actual: dash
Unordered list style
596-596: Expected: asterisk; Actual: dash
Unordered list style
600-600: Expected: asterisk; Actual: dash
Unordered list style
601-601: Expected: asterisk; Actual: dash
Unordered list style
602-602: Expected: asterisk; Actual: dash
Unordered list style
612-612: Expected: asterisk; Actual: dash
Unordered list style
613-613: Expected: asterisk; Actual: dash
Unordered list style
624-624: Expected: asterisk; Actual: dash
Unordered list style
628-628: Expected: asterisk; Actual: dash
Unordered list style
629-629: Expected: asterisk; Actual: dash
Unordered list style
630-630: Expected: asterisk; Actual: dash
Unordered list style
631-631: Expected: asterisk; Actual: dash
Unordered list style
632-632: Expected: asterisk; Actual: dash
Unordered list style
633-633: Expected: asterisk; Actual: dash
Unordered list style
635-635: Expected: asterisk; Actual: dash
Unordered list style
636-636: Expected: asterisk; Actual: dash
Unordered list style
644-644: Expected: asterisk; Actual: dash
Unordered list style
648-648: Expected: asterisk; Actual: dash
Unordered list style
652-652: Expected: asterisk; Actual: dash
Unordered list style
662-662: Expected: asterisk; Actual: dash
Unordered list style
663-663: Expected: asterisk; Actual: dash
Unordered list style
664-664: Expected: asterisk; Actual: dash
Unordered list style
665-665: Expected: asterisk; Actual: dash
Unordered list style
671-671: Expected: asterisk; Actual: dash
Unordered list style
672-672: Expected: asterisk; Actual: dash
Unordered list style
676-676: Expected: asterisk; Actual: dash
Unordered list style
34-34: null
Emphasis used instead of a heading
42-42: null
Emphasis used instead of a heading
54-54: null
Emphasis used instead of a heading
62-62: null
Emphasis used instead of a heading
70-70: null
Emphasis used instead of a heading
78-78: null
Emphasis used instead of a heading
92-92: null
Emphasis used instead of a heading
110-110: null
Emphasis used instead of a heading
144-144: null
Emphasis used instead of a heading
157-157: null
Emphasis used instead of a heading
247-247: null
Emphasis used instead of a heading
267-267: null
Emphasis used instead of a heading
275-275: null
Emphasis used instead of a heading
289-289: null
Emphasis used instead of a heading
303-303: null
Emphasis used instead of a heading
311-311: null
Emphasis used instead of a heading
319-319: null
Emphasis used instead of a heading
329-329: null
Emphasis used instead of a heading
337-337: null
Emphasis used instead of a heading
345-345: null
Emphasis used instead of a heading
353-353: null
Emphasis used instead of a heading
364-364: null
Emphasis used instead of a heading
372-372: null
Emphasis used instead of a heading
381-381: null
Emphasis used instead of a heading
395-395: null
Emphasis used instead of a heading
403-403: null
Emphasis used instead of a heading
407-407: null
Emphasis used instead of a heading
436-436: null
Emphasis used instead of a heading
444-444: null
Emphasis used instead of a heading
464-464: null
Emphasis used instead of a heading
502-502: null
Emphasis used instead of a heading
511-511: null
Emphasis used instead of a heading
519-519: null
Emphasis used instead of a heading
534-534: null
Emphasis used instead of a heading
546-546: null
Emphasis used instead of a heading
561-561: null
Emphasis used instead of a heading
583-583: null
Emphasis used instead of a heading
604-604: null
Emphasis used instead of a heading
615-615: null
Emphasis used instead of a heading
638-638: null
Emphasis used instead of a heading
654-654: null
Emphasis used instead of a heading
Additional comments not posted (1)
CHANGELOG.md (1)
23-23: Ensure the entry for PR #1431 is correctly categorized and detailed.The entry for PR #1431 under "Improvements" correctly categorizes the integration of Testground for benchmarking as an improvement to the system. The link and description are clear and direct users to the appropriate PR for more details.
* Problem: no cluster benchmarking - Integrate testground - Implement python sdk for testground * cleanup * cleanup * cleanup * show case interaction with cronosd binary * simpler subscribe api * composition * use pydantic models * fix flaky * update readme * bootstrap genesis * setup peers * fix genesis * fix genesis, finally generating blocks * remove pystarport dependency * better halting * tx sending * remove assertion * fix ckzg build * node counts * readme * changelog
NOTE
Need this patch on testground to support the docker image building with nix: testground/testground#1594
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
New Features
Bug Fixes
.gitignoreto correctly ignore theresultdirectory.Documentation
README.mdfor Testground setup and usage.Chores
CHANGELOG.mdto reflect the integration of Testground for cluster benchmarks.