Problem: multi-threading tx sending not efficient

[yihuang]

Solution:

• gen txs in advance
• use asyncio

block 2 0 2024-09-18 04:56:20.670280+00:00 0
block 3 0 2024-09-18 04:56:22.082888+00:00 0.0
block 4 0 2024-09-18 04:56:23.403651+00:00 0.0
block 5 4 2024-09-18 04:56:24.923691+00:00 0.9404216991962451
block 6 7761 2024-09-18 04:56:27.809525+00:00 1087.6500246174492
block 7 7761 2024-09-18 04:56:37.445181+00:00 925.5494264913992
block 8 7761 2024-09-18 04:56:40.000103+00:00 1204.7187395352767
block 9 7761 2024-09-18 04:56:42.509755+00:00 1421.645895791909
block 10 952 2024-09-18 04:56:44.943279+00:00 1318.3373014599474

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Introduced asynchronous transaction preparation and sending for improved performance.
  • Added new helper functions for transaction creation and processing.
  • Enhanced transaction handling with consolidated account data processing.

• Bug Fixes

  • Streamlined transaction handling logic to enhance efficiency and clarity.

• Chores

  • Updated project dependencies to include ujson for improved JSON handling.
  • Reduced job configurations in the Docker Compose setup for better resource management.

[coderabbitai]

Walkthrough

The pull request introduces several modifications in the testground/benchmark/benchmark/sendtx.py file, enhancing transaction handling functionality. Key changes include the addition of a helper function test_tx for creating transaction dictionaries, the removal of the cli parameter from generate_load, and the introduction of new functions prepare_txs and send_txs for preparing and asynchronously sending transactions. These updates streamline transaction processing and improve code clarity.

Changes

File	Change Summary
testground/benchmark/benchmark/sendtx.py	Added test_tx helper function; modified sendtx and generate_load; introduced prepare_txs and send_txs for transaction handling.

Possibly related PRs

• Problem: testground block stats don't calculate tps directly #1586: The changes in stateless.py involve removing functions that interact with a local RPC server, which may relate to the modifications in sendtx.py that enhance transaction handling and RPC interactions.

Suggested reviewers

• JayT106
• thomas-nguy
• mmsqe

🐇 "In the code we hop and play,
With functions new, we clear the way.
Transactions swift, no time to waste,
With every change, we pick up pace!
So let us cheer, with joy we sing,
For every tweak, a brighter spring!" 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1e299dd and 421059a.

Files selected for processing (1)

• testground/benchmark/benchmark/sendtx.py (4 hunks)

Additional comments not posted (10)

testground/benchmark/benchmark/sendtx.py (10)

1-5: LGTM!

The new imports are relevant to the changes made in the file and will be used for asynchronous programming and faster JSON serialization.

---

13-15: LGTM!

The new constants are used to avoid hardcoding values and are set to reasonable values.

---

18-26: LGTM!

The new test_tx function is a helper function that creates a test transaction dictionary with the necessary fields. It will be useful for creating test transactions with a given nonce.

---

43-43: LGTM!

The send_transaction function call is updated to use the new test_tx helper function, which is a good use of the helper function.

---

68-70: LGTM!

The changes to the generate_load function are good:

• Removing the unused cli parameter simplifies the function signature.
• Updating the assertion to use the CHAIN_ID constant avoids hardcoding the value.

---

81-90: LGTM!

The new prepare_txs function is a useful addition that generates a list of signed raw transaction hex strings. It will be helpful for preparing transactions in advance.

---

93-106: LGTM!

The new async_sendtx function is a useful addition that sends a raw transaction asynchronously using the provided session. It handles the JSON RPC request and response correctly.

---

108-114: LGTM!

The new send_txs function is a great addition that sends a list of raw transactions asynchronously using aiohttp. It utilizes the async_sendtx function and asyncio.gather to send the transactions concurrently, which should improve the performance of sending transactions.

---

86-86: Skipping the past review comment.

The current line already uses the rawTransaction.hex() method to get the signed transaction hex string, as suggested in the past review comment. The comment is no longer applicable.

---

43-43: Skipping the past review comment.

The current line already sets wait=False when calling the send_transaction function, as suggested in the past review comment. The comment is no longer applicable.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
pypi/ujson@5.10.0	environment, eval, filesystem, shell, unsafe	0	20.4 MB	Jonas.Tarnstrom, cgbystrom, hugovk, ...1 more

View full report↗︎

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.24%. Comparing base (e0d64e9) to head (421059a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1587   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files          67       67           
  Lines        4874     4874           
=======================================
  Hits          743      743           
  Misses       4037     4037           
  Partials       94       94