Problem: test tx generation can't be run in parallel

[yihuang]

Solution:

• support generating a single node and use shell to parallelize it

for example:

$ seq 0 9 | xargs -P10 -I{} nix run .#stateless-testcase -- gen-txs /tmp/data/out --node {}

Run nix run .#stateless-testcase -- --help to make sure it's built first, because the build part can't run in parallel.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features
  • Introduced an optional command-line argument --node for specifying a single node during transaction generation.
• Bug Fixes
  • Adjusted account handling to exclude the first account from the generated list, ensuring accurate account representation for subsequent nodes.

[coderabbitai]

Walkthrough

The changes involve modifications to the gen_genesis function in peer.py, specifically adjusting the handling of the accounts list to exclude the first account, which is the validator account of the first node. Additionally, an optional command-line argument --node is introduced in the gen_txs function in stateless.py, allowing users to generate transactions for a specific node. The function signatures are updated accordingly, and the path for preparing the genesis file is changed.

Changes

File Path	Change Summary
testground/benchmark/benchmark/peer.py	Modified gen_genesis function to skip the first account in the accounts list, ensuring only subsequent nodes are included.
testground/benchmark/benchmark/stateless.py	Updated gen_txs and _gen_txs function signatures to include an optional node parameter. Logic modified to generate transactions conditionally based on the presence of node. Path for genesis file preparation changed from FULLNODE_GROUP to VALIDATOR_GROUP.

Possibly related PRs

• Problem: testground can't patch genesis #1574: Modifies the gen_genesis function in peer.py, directly related to the changes in the main PR.
• Problem: testground block stats don't calculate tps directly #1586: Introduces a new TPS calculation feature in stateless.py, relevant to the changes in transaction handling.
• Problem: multi-threading tx sending not efficient #1587: Enhances transaction handling in sendtx.py, related to modifications in the accounts list and transaction generation logic.

🐇 In the meadow, transactions flow,
With a node to guide, watch them grow.
A sprinkle of code, a dash of delight,
Generating paths, both day and night.
Hops of joy in every line,
A new feature's here, oh how divine! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cf373d1 and b003339.

Files selected for processing (2)

• testground/benchmark/benchmark/peer.py (1 hunks)
• testground/benchmark/benchmark/stateless.py (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• testground/benchmark/benchmark/stateless.py

Additional comments not posted (1)

testground/benchmark/benchmark/peer.py (1)

89-93: LGTM!

The code change correctly skips the first account in the accounts list, which corresponds to the validator account of the first node. This prevents duplicating the validator account in the genesis file, as it is already added using the home directory of that node.

The updated logic ensures that the accounts list only contains the accounts from the subsequent nodes, which is the desired behavior.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.24%. Comparing base (670fd8d) to head (cf373d1).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files          67       67           
  Lines        4874     4874           
=======================================
  Hits          743      743           
  Misses       4037     4037           
  Partials       94       94