Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: tx gas limit is not capped in web3 rpc api #216

Closed
wants to merge 2 commits into from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 17, 2021

Solution:

  • add tx gas limit cap in web3 rpc api

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner November 17, 2021 06:46
@yihuang yihuang requested review from devashishdxt, leejw51crypto and thomas-nguy and removed request for a team November 17, 2021 06:46
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #216 (95e77a8) into main (3ea70c5) will increase coverage by 5.21%.
The diff coverage is 55.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   21.51%   26.73%   +5.21%     
==========================================
  Files          27       33       +6     
  Lines        1729     2338     +609     
==========================================
+ Hits          372      625     +253     
- Misses       1324     1666     +342     
- Partials       33       47      +14     
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 4.76% <0.00%> (-1.69%) ⬇️
x/cronos/module.go 59.64% <0.00%> (-2.17%) ⬇️
x/cronos/types/codec.go 0.00% <ø> (ø)
x/cronos/types/contracts.go 65.00% <ø> (ø)
x/cronos/types/events.go 0.00% <ø> (ø)
x/cronos/types/messages.go 20.22% <ø> (+20.22%) ⬆️
x/cronos/types/params.go 57.35% <ø> (+3.78%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4725cf0...95e77a8. Read the comment docs.

Solution:
- a temporary fix to limit gas at rpc level, the real fix is breaking one, will be released later.
@yihuang yihuang changed the title Problem: gas is not refunded when transaction reverted [temporary fix] Problem: gas is not refunded when transaction reverted Nov 17, 2021
@yihuang yihuang changed the title [temporary fix] Problem: gas is not refunded when transaction reverted Problem: gas limit is not capped in web3 rpc api Nov 17, 2021
@yihuang yihuang changed the title Problem: gas limit is not capped in web3 rpc api Problem: tx gas limit is not capped in web3 rpc api Nov 17, 2021
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing an official release

#217

@yihuang
Copy link
Collaborator Author

yihuang commented Nov 19, 2021

superseded by #217

@yihuang yihuang closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants