Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: v0.6.2 #217

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner November 17, 2021 13:32
@thomas-nguy thomas-nguy requested review from yihuang and JayT106 and removed request for a team November 17, 2021 13:32
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #217 (bb0963c) into main (3ea70c5) will increase coverage by 5.21%.
The diff coverage is 55.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   21.51%   26.73%   +5.21%     
==========================================
  Files          27       33       +6     
  Lines        1729     2338     +609     
==========================================
+ Hits          372      625     +253     
- Misses       1324     1666     +342     
- Partials       33       47      +14     
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 4.76% <0.00%> (-1.69%) ⬇️
x/cronos/module.go 59.64% <0.00%> (-2.17%) ⬇️
x/cronos/types/codec.go 0.00% <ø> (ø)
x/cronos/types/contracts.go 65.00% <ø> (ø)
x/cronos/types/events.go 0.00% <ø> (ø)
x/cronos/types/messages.go 20.22% <ø> (+20.22%) ⬆️
x/cronos/types/params.go 57.35% <ø> (+3.78%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4725cf0...bb0963c. Read the comment docs.

@thomas-nguy
Copy link
Collaborator Author

for reference, the diff can be seen there

crypto-org-chain/ethermint#13

@thomas-nguy thomas-nguy force-pushed the thomas/v0.6.2 branch 2 times, most recently from 834595d to 4c0cf46 Compare November 17, 2021 13:58
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,6 +2,18 @@

## Unreleased

*November 19, 2021*

## v0.6.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that change in gRPC (QueryAccountRequest) breaking -- i.e. will the v0.6.1 binary still be able to use that query against v0.6.2 node?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok. Ethermint does not provide any query command and cronos query commands do not use it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, to my limited understanding, it's only adding a few fields, so most protobuf tooling should be fine (deserialisers in the old version would ignore it / put it in unknown fields: https://developers.google.com/protocol-buffers/docs/proto3#unknowns )

Copy link
Collaborator

@yihuang yihuang Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only API change is the TraceTx and TraceBlock, they are not exposed through CLI I think.

@thomas-nguy thomas-nguy merged commit 079f766 into crypto-org-chain:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants