-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: v0.6.2 #217
Release: v0.6.2 #217
Conversation
8481faf
to
4245ee0
Compare
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 21.51% 26.73% +5.21%
==========================================
Files 27 33 +6
Lines 1729 2338 +609
==========================================
+ Hits 372 625 +253
- Misses 1324 1666 +342
- Partials 33 47 +14
Continue to review full report at Codecov.
|
for reference, the diff can be seen there |
834595d
to
4c0cf46
Compare
4c0cf46
to
bb0963c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2,6 +2,18 @@ | |||
|
|||
## Unreleased | |||
|
|||
*November 19, 2021* | |||
|
|||
## v0.6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that change in gRPC (QueryAccountRequest
) breaking -- i.e. will the v0.6.1 binary still be able to use that query against v0.6.2 node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ok. Ethermint does not provide any query command and cronos query commands do not use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crypto-org-chain/ethermint@9f1478e#diff-324e7e7d0d1ab912bb60777c369af7304487e0a49727c3b9cf600ae9ef7865caL6
Is it this one? it looks like the only protobuf change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, to my limited understanding, it's only adding a few fields, so most protobuf tooling should be fine (deserialisers in the old version would ignore it / put it in unknown fields: https://developers.google.com/protocol-buffers/docs/proto3#unknowns )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only API change is the TraceTx
and TraceBlock
, they are not exposed through CLI I think.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)