Removed dependency of openssl.ripemd160 and replaced it by embit dependency #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency. This is useful because embit handles the missing ripemd160 in openssl3: diybitcoinhardware/embit#28 starting from version 0.4.13
✅ Deploy Preview for specter-desktop-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
14 tasks
|
@k9ert : Could you review? |
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
…er-desktop into fix_ripemd160
|
I've created a test for this and tried to improve the test-framework along the way. If test goes through, happy to merge but please, @relativisticelectron have a look before as well. |
moneymanolis
reviewed
May 5, 2022
k9ert
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dependency of openssl.ripemd160 and replaced it by embit dependency
This is useful because embit handles the missing ripemd160 in openssl3: diybitcoinhardware/embit#28 starting from version 0.4.13
see also: #1688 (comment)