Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RIPEMD160 missing in Openssl3 #28

Closed
relativisticelectron opened this issue May 3, 2022 · 1 comment
Closed

RIPEMD160 missing in Openssl3 #28

relativisticelectron opened this issue May 3, 2022 · 1 comment

Comments

@relativisticelectron
Copy link

relativisticelectron commented May 3, 2022 •
edited
Loading

Openssl was upgraded to 3.0.2 in ubuntu 22.04.

Problem: RIPEMD160 was deactivated in Openssl3 openssl/openssl#16994 and embit uses openssl for this in

embit/src/embit/hashes.py

Line 12 in 977d144

return hashlib.new('ripemd160', hashlib.sha256(msg).digest()).digest()

This problem has been discussed on hwi: bitcoin-core/HWI#305
Possible solution through a Python-only implementation: Bitcoin test framework: bitcoin/bitcoin@68ca867
@relativisticelectron relativisticelectron mentioned this issue May 3, 2022
Merged
14 tasks
@stepansnigirev
Copy link
Contributor

Fixed via 2e293b0

relativisticelectron added a commit to relativisticelectron/specter-desktop that referenced this issue May 5, 2022
@relativisticelectron
Removed dependency of openssl.ripemd160 and replaced it by embit depe…
0a0543a 
…ndency.

This is useful because embit handles the missing ripemd160 in openssl3: diybitcoinhardware/embit#28 starting from version 0.4.13
@relativisticelectron relativisticelectron mentioned this issue May 5, 2022
Merged
k9ert added a commit to cryptoadvance/specter-desktop that referenced this issue May 5, 2022
@relativisticelectron @stepansnigirev @k9ert
Chore: embit Upgrade to 0.4.13 (ripemd160 replacement) (#1702)
b5bf6f1 
* Removed dependency of openssl.ripemd160  and replaced it by embit dependency.
This is useful because embit handles the missing ripemd160 in openssl3: diybitcoinhardware/embit#28 starting from version 0.4.13

* Update src/cryptoadvance/specter/devices/specter.py

Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>

* dependencies and tests

* fix tests

* rollback unintended changes

Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
Co-authored-by: Kim Neunert <k9ert@gmx.de>
Closed
@odudex odudex mentioned this issue May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stepansnigirev @relativisticelectron