mitigating taproot hotwallet issue 2078 #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs canceled.
|
k9ert
commented
Jan 27, 2023
k9ert
commented
Jan 27, 2023
k9ert
commented
Jan 27, 2023
moneymanolis
approved these changes
Jan 27, 2023
k9ert
added a commit
to k9ert/specter-desktop
that referenced
this pull request
Jan 27, 2023
* Some smaller improvements and fixes * mitigating 2078 * removed Microsoft link tracking * wrap up a failed update properly * better decode and better error_handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigating #2078 . As this is not properly fixed, as a side-effect it could be that transactions and utxos are shown which are not belonging to the taproot wallet.
Also in the first commit, there are some smaller fixes.