Bugfix: fixes/2078 for the uiux-revamp branch (mitigating taproot issue) #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs canceled.
|
* Some smaller improvements and fixes * mitigating 2078 * removed Microsoft link tracking * wrap up a failed update properly * better decode and better error_handling
k9ert
force-pushed
the
uiux/fixes/2078
branch
from
b956f36
to
5454533
Compare
k9ert
changed the title
src/cryptoadvance/specter/txlist.py
Outdated
| super_dict["utxo_amount"] = self.utxo_amount | ||
| super_dict["ismine"] = (self["ismine"] or self.ismine,) | ||
| return super_dict | ||
| # def __dict__(self): |
There was a problem hiding this comment.
Why is this commented out? If not needed, I'd rather delete.
moneymanolis
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applies #2087 to uiux-revamp. No special changes for v2 needed!
original bug: #2078