Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trouble running make on master branch #1654

Closed
michielbdejong opened this issue Apr 21, 2021 · 1 comment
Closed

Trouble running make on master branch #1654

michielbdejong opened this issue Apr 21, 2021 · 1 comment

Comments

@michielbdejong
Copy link
Contributor 

[...]
go: downloading golang.org/x/crypto v0.0.0-20190911031432-227b76d455e7
`go env GOPATH`/bin/calens > /dev/null
go run tools/check-changelog/main.go
2021/04/21 13:51:51 No changelog added. Please create a changelog item based on your changes
exit status 1
make: *** [check-changelog] Error 1

I'm trying to work around this now with

go run tools/prepare-release/main.go --version unreleased
@ishank011
Copy link
Contributor

We expect a changelog to be added whenever any changes are made. You can run make build to skip this check.

michielbdejong added a commit that referenced this issue Apr 22, 2021
@michielbdejong
make build instead of make
df9660a 
The current 'Build and run it yourself' instructions from the readme will fail if there are unreleased changes, as described in #1654.
As per #1654 (comment), it should however be enough to run `make build` instead of the `make` step.
@michielbdejong michielbdejong mentioned this issue Apr 22, 2021
Closed
michielbdejong added a commit that referenced this issue Apr 22, 2021
@michielbdejong
[docs-only] Run make build instead of make
a10a539 
The current 'Build and run it yourself' instructions from the readme will fail if there are unreleased changes, as described in #1654.
As per #1654 (comment), it should however be enough to run `make build` instead of the `make` step.
@michielbdejong michielbdejong mentioned this issue Apr 22, 2021
Merged
michielbdejong added a commit that referenced this issue Apr 22, 2021
@michielbdejong
[docs-only] Fix "build from sources" instructions
48b3548 
Use `make build` instead of `make` in "build from sources" instructions, as per #1654.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michielbdejong @ishank011