[docs-only] Run make build instead of make
#1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Hm, seems that the |
Use `make build` instead of `make` in "build from sources" instructions, as per #1654.
Apart from /var/tmp/reva/, /etc/revad/ will need to be created, and editing anything under /etc will require sudo.
ishank011
reviewed
Apr 22, 2021
README.md
Outdated
| $ cd examples/storage-references | ||
| $ ../../cmd/revad/revad -dev-dir . | ||
| $ make build | ||
| $ sudo mkdir -p /etc/revad |
There was a problem hiding this comment.
Can you remove sudo from the commands? We don't want to assume access control.
Not merged yet #1655 |
ishank011
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 'Build and run it yourself' instructions from the readme will fail if there are unreleased changes, as described in #1654.
As per #1654 (comment), it should however be enough to run
make buildinstead of themakestep.Continued from #1657.