Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] Run make build instead of make #1658

Merged
merged 5 commits into from
Apr 26, 2021
Merged

[docs-only] Run make build instead of make #1658

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a10a539
[docs-only] Run `make build` instead of `make`
michielbdejong Apr 22, 2021
48b3548
[docs-only] Fix "build from sources" instructions
michielbdejong Apr 22, 2021
dde4070
[docs-only] Fix #1659, initialise /etc/revad
michielbdejong Apr 22, 2021
a1773ea
[docs-only] Fix code to initialise /etc/revad/
michielbdejong Apr 22, 2021
1f0e879
Remove sudo commands
michielbdejong Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,15 @@ You need to have [Go](https://golang.org/doc/install), [git](https://git-scm.com
$ git clone https://github.com/cs3org/reva
$ cd reva
$ make deps
$ make
$ cd examples/storage-references
$ ../../cmd/revad/revad -dev-dir .
$ make build
$ sudo mkdir -p /etc/revad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove sudo from the commands? We don't want to assume access control.

$ sudo cp examples/storage-references/users.demo.json /etc/revad/users.json
$ sudo cp examples/storage-references/groups.demo.json /etc/revad/groups.json
$ sudo cp examples/storage-references/providers.demo.json /etc/revad/ocm-providers.json
$ cmd/revad/revad -dev-dir examples/storage-references
```

You can also read the [build from sources guide](https://reva.link/docs/getting-started/build-reva/).
You can also read the [build from sources guide](https://reva.link/docs/getting-started/build-reva/) and the [setup tutorial](https://github.com/cs3org/reva/blob/master/docs/content/en/docs/tutorials/setup-tutorial.md).

## Run tests

Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/getting-started/build-reva.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ the Go programming language that installs the Go compiler.
git clone https://github.com/cs3org/reva
cd reva
make deps
make
make build
```
7 changes: 4 additions & 3 deletions docs/content/en/docs/tutorials/setup-tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,10 @@ You can start these three daemons using the `-dev-dir` flag which fires up a dae

```
> mkdir -p /var/tmp/reva
> cp examples/storage-references/users.demo.json /etc/revad/users.json
> cp examples/storage-references/groups.demo.json /etc/revad/groups.json
> cp examples/storage-references/providers.demo.json /etc/revad/ocm-providers.json
> sudo mkdir -p /etc/revad
> sudo cp examples/storage-references/users.demo.json /etc/revad/users.json
> sudo cp examples/storage-references/groups.demo.json /etc/revad/groups.json
> sudo cp examples/storage-references/providers.demo.json /etc/revad/ocm-providers.json
> cmd/revad/revad -dev-dir examples/storage-references
```

Expand Down