return the users username instead of the uuid in share responses #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested changes
Dec 14, 2020
| // UserServiceUserIDResolver returns a userId resolver using the UserService | ||
| func UserServiceUserIDResolver(ctx context.Context, client gatewayv1beta1.GatewayAPIClient) func(*userpb.UserId) (string, error) { | ||
| return func(id *userpb.UserId) (string, error) { | ||
| resp, err := client.GetUser(ctx, &userpb.GetUserRequest{UserId: id}) |
There was a problem hiding this comment.
this must be cached, otherwise we will make an rpc to the gateway and then to the user provider, probably to ldap ... and back, several times per file list entry ...
There was a problem hiding this comment.
Ugh... I think this is also causing the tests to fail... The ldap server gets overwhelmed and then crashes...
Locally the pipelines work... 😞
There was a problem hiding this comment.
I implemented the username lookup similar to the display name lookup which you implemented. Including the caching.
C0rby
force-pushed
the
change/ocs-share-api-userid
branch
2 times, most recently
from
a712017
to
1af72bb
Compare
kulmann
approved these changes
Dec 15, 2020
C0rby
force-pushed
the
change/ocs-share-api-userid
branch
from
1af72bb
to
2431424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we decided to use the users uuid only internally and to only display or return the users username. The ocs share api did still return the uuid.
Closes owncloud/ocis#990