[oC-Web] sharing broken in shared with others view

[exalate-issue-sync]

When opening the right sidebar for a resource in the shared with others view, both the People and the Links accordion items are "broken", as in:

1. People shows a No permission to share this folder text at the same location where the button for adding people usually is. As this is the shared with others page, I'm clearly the owner of the resource, so I should be allowed to share it from here.
   2) Links shows the button for creating a new public link, but upon submitting the form there is a resource not found error message.

This happens on ocis only.

[exalate-issue-sync]

Lukas Hirt commented: 1. Is because we are not checking for share permissions of the owner but of the user with whom the file is shared. So if we share a file with Marie and give her role Viewer, the webUI assumes that we have also only view permission on the file in "Shared with others" list. When we receive username instead of UUID as the shareowner, we can compare it with the currently logged in user and enable sharing.

2. I didn't manage to reproduce this. Creating the link works just fine for me there. 🤷

[exalate-issue-sync]

Benedikt Kulmann commented: Crossed out the second bug. Apparently that was happening on a share that was not removed upon folder deletion.

[exalate-issue-sync]

Benedikt Kulmann commented: Implemented in reva, needs to be merged and then updated in ocis.