Fix Statcache issue #2351
Merged
Fix Statcache issue #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kobergj
requested review from
glpatcern,
ishank011,
labkode and
a team
as code owners
|
@rhafer this should fix the (locally) failing test in ci and on local. Please double check! |
rhafer
suggested changes
Dec 13, 2021
There was a problem hiding this comment.
this should fix the (locally) failing test in ci and on local. Please double check!
Yeah, this works locally here now was well. Thanks.
This looks good to me overall. Though I would really like to avoid adding the hardcoded spaceid here. Is there a way we can move that into a constant?
rhafer
approved these changes
Dec 13, 2021
Merged
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statcache is not working correctly. Some tests fail in local but are green on ci.
Goals:
Note: The order is important