-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ServiceAccount Permissions #4544
Closed
kobergj
wants to merge
1,917
commits into
cs3org:master
from
kobergj:AddCreateContainerToServiceAccounts
Closed
Extend ServiceAccount Permissions #4544
kobergj
wants to merge
1,917
commits into
cs3org:master
from
kobergj:AddCreateContainerToServiceAccounts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the calling service for permission checks, we're now checking if the requesting user has sufficient permission for performing an update in the shareprovider itself.
Check the UpateShare call for success, before trying ot update the grants on the shared resource.
Bump golangci-lint to v1.55.2, the old version we had seems to cause issues with some go1.21 code. Also remove some deprecated linters that no longer seem to work correctly. Also bump setup-go to v4 (as in master).
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
feat: add permission checking to public share provider
Rework Cache Configuration
Signed-off-by: jkoberg <jkoberg@owncloud.com>
usershareprovider: check permissions before updating a share
added the ability to disable the password policy
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Implement OCM TUS uploads
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix upload binPath Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
align some ocs status codes
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
jsoncs3 cache fixes
The fetchShares call is already stat'ing the resource a few lines above. If that didn't return and info, why should it do here?
When listing the sharejail root, merge shares that target the same resource into a single resource. In order to avoid the resourceId changing randomly the id will be composed from the oldest accepted share that exist for the resource. Ideally we'd compose the resourceId based on the id of the shared resource, but that is currently not possible in a backwards compatible way. Some clients seem to rely on the fact that the resource ids in the sharejail contain valid shareids. Fixes: owncloud/ocis#8080
fix(sharesstorageprovider): Merge shares of the same resourceid
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
…check drop unnecessary grant exists check
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
…an-purge Fix recursive trashcan purge
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Release 2.19.0
fix remove/update share permissions when the file is locked
[full-ci] release-2.19.1
[tests-only][full-ci]bump latest ocis commit id
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK
#2621)space_ref
, usespace
instead (Deprecatespace_ref
, usespace
instead #2913)application/x-www-form-urlencoded
for the app provider http endpoint (use Form instead of Query to also supportapplication/x-www-form-urlencoded
for the app provider http endpoint #3098)reva-edge
#3188)reva-edge
([tests-only] Bump core commit id to latestreva-edge
#3212)reva-edge
#3363)reva-edge
#3558)reva-edge
([tests-only]Bump core latest commit id onreva-edge
#3573)ocis-commit
it toreva-edge
([tests-only][full-ci]Bumpocis-commit
it toreva-edge
#3616)reva edge
#3632)reva-edge
([full-ci] [tests-only] Bump ocis commit idreva-edge
#3659)edge
([full-ci] [tests-only] Bump ocis commit id to latestedge
#3708)/changes
toplevel dirtrue