Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add driveAlias #2623

Merged
merged 6 commits into from
Mar 15, 2022
Merged

add driveAlias #2623

merged 6 commits into from
Mar 15, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Mar 7, 2022

Description

Implements the base features for space aliases as a space property in the decomposedFS

Detailed description

owncloud/ocis#3283 (comment)

@micbar micbar force-pushed the add-alias branch 2 times, most recently from c482b2f to 40f7f00 Compare March 8, 2022 23:06
@micbar
Copy link
Member Author

micbar commented Mar 8, 2022

I discovered a possible problem in

if link[0:10] != "....spaces" || link[46:51] != "nodes" {

We cannot assume that the length is as we expect it to be. I found that during unit testing.
../../spaces/4c/510ada-c86b-4815-8820-42cdf82c3d51/nodes/4c/51/0a/da/-c86b-4815-8820-42cdf82c3d51 could be
../../spaces/us/erid/nodes/4c/51/0a/da/-c86b-4815-8820-42cdf82c3d51

  1. Create a user with a userid which is not UUIDv4
  2. Log in, we will create a personal space with the userid as spaceID
  3. the string will be shorter as we expect it

@micbar micbar marked this pull request as ready for review March 9, 2022 09:52
@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners March 9, 2022 09:52
@micbar micbar requested review from C0rby and kobergj March 9, 2022 10:13
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question

pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
@micbar micbar requested a review from kobergj March 9, 2022 11:53
@micbar
Copy link
Member Author

micbar commented Mar 9, 2022

@kobergj I added configurable template strings.

Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks still good to me 👍

@micbar micbar marked this pull request as draft March 11, 2022 11:34
@micbar micbar marked this pull request as draft March 11, 2022 11:34
@micbar
Copy link
Member Author

micbar commented Mar 11, 2022

general approach needs to be discussed

@dragotin FYI

@micbar micbar requested a review from butonic March 14, 2022 16:49
@micbar micbar marked this pull request as ready for review March 14, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants