-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add driveAlias #2623
add driveAlias #2623
Conversation
5a5c410
to
63eccf8
Compare
c482b2f
to
40f7f00
Compare
I discovered a possible problem in reva/pkg/storage/utils/decomposedfs/spaces.go Line 223 in 40f7f00
We cannot assume that the length is as we expect it to be. I found that during unit testing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small question
@kobergj I added configurable template strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks still good to me 👍
general approach needs to be discussed @dragotin FYI |
Description
Implements the base features for space aliases as a space property in the decomposedFS
Detailed description
owncloud/ocis#3283 (comment)