use tls for nats connections #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
micbar
approved these changes
Oct 11, 2022
|
There is only a changelog missing and a CI run. |
butonic
reviewed
Oct 12, 2022
| @@ -209,6 +214,32 @@ func publisherFromConfig(m map[string]interface{}) (events.Publisher, error) { | |||
| case "nats": | |||
| address := m["address"].(string) | |||
| cid := m["clusterID"].(string) | |||
| return server.NewNatsStream(natsjs.Address(address), natsjs.ClusterID(cid)) | |||
|
|
|||
| skipVerify := m["tls-insecure"].(bool) | |||
There was a problem hiding this comment.
this leads to a panic if unset:
panic: interface conversion: interface {} is nil, not bool
goroutine 280 [running]:
github.com/cs3org/reva/v2/internal/grpc/interceptors/eventsmiddleware.publisherFromConfig(0xc0016ee180)
/home/vscode/repositories/reva/internal/grpc/interceptors/eventsmiddleware/events.go:218 +0x8a5
github.com/cs3org/reva/v2/internal/grpc/interceptors/eventsmiddleware.NewUnary(0xc0016ee180)
/home/vscode/repositories/reva/internal/grpc/interceptors/eventsmiddleware/events.go:60 +0x5f
github.com/cs3org/reva/v2/pkg/rgrpc.(*Server).getInterceptors(0xc0009f6c80, {0x5ddfb08, 0x0, 0x0})
/home/vscode/repositories/reva/pkg/rgrpc/rgrpc.go:257 +0x1ae
github.com/cs3org/reva/v2/pkg/rgrpc.(*Server).registerServices(0xc0009f6c80)
/home/vscode/repositories/reva/pkg/rgrpc/rgrpc.go:198 +0x7cd
github.com/cs3org/reva/v2/pkg/rgrpc.(*Server).Start(0xc0009f6c80, {0x49bbe78, 0xc00077c378})
/home/vscode/repositories/reva/pkg/rgrpc/rgrpc.go:143 +0x51
github.com/cs3org/reva/v2/cmd/revad/runtime.start.func2()
/home/vscode/repositories/reva/cmd/revad/runtime/runtime.go:200 +0xae
created by github.com/cs3org/reva/v2/cmd/revad/runtime.start
/home/vscode/repositories/reva/cmd/revad/runtime/runtime.go:199 +0x211
73 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config option to skip server certificate verification. This is needed when running a nats server with self signed certificates.