Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta ids #2793

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Meta ids #2793

merged 1 commit into from
Apr 29, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Apr 28, 2022

Description

Add IDs to dav/meta response.

@update-docs
Copy link

update-docs bot commented Apr 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar changed the base branch from master to edge April 28, 2022 17:42
@cs3org cs3org deleted a comment from sonarcloud bot Apr 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 240 Code Smells

No Coverage information No Coverage information
9.0% 9.0% Duplication

@micbar micbar marked this pull request as ready for review April 29, 2022 08:19
@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners April 29, 2022 08:19
@micbar micbar merged commit 599bdac into cs3org:edge Apr 29, 2022
@@ -142,6 +142,9 @@ func (h *MetaHandler) handlePathForUser(w http.ResponseWriter, r *http.Request,
Status: "HTTP/1.1 200 OK",
Prop: []prop.PropertyXML{
prop.Escaped("oc:meta-path-for-user", pathRes.Path),
prop.Escaped("oc:id", id),
prop.Escaped("oc:fileid", id),
prop.Escaped("oc:spaceid", rid.GetStorageId()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is space ID and StorageId really the same? Looks confusing to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...can and should be changed to make the world less confusing....
Or? Are we talking about a space or a storage? IIRC that is a difference, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be discussed before we freeze the CS3Apis. StorageID was the property which was already there and we use it as the spaceID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants