Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta ids #2793

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Meta ids #2793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/unreleased/meta-path-for-user.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ Enhancement: Meta path for user
We've added support for requesting the `meta-path-for-user` via a propfind to the `dav/meta/<id>` endpoint.

https://github.com/cs3org/reva/pull/2741
https://github.com/cs3org/reva/pull/2793
https://doc.owncloud.com/server/next/developer_manual/webdav_api/meta.html
3 changes: 3 additions & 0 deletions internal/http/services/owncloud/ocdav/meta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ func (h *MetaHandler) handlePathForUser(w http.ResponseWriter, r *http.Request,
Status: "HTTP/1.1 200 OK",
Prop: []prop.PropertyXML{
prop.Escaped("oc:meta-path-for-user", pathRes.Path),
prop.Escaped("oc:id", id),
prop.Escaped("oc:fileid", id),
prop.Escaped("oc:spaceid", rid.GetStorageId()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is space ID and StorageId really the same? Looks confusing to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...can and should be changed to make the world less confusing....
Or? Are we talking about a space or a storage? IIRC that is a difference, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be discussed before we freeze the CS3Apis. StorageID was the property which was already there and we use it as the spaceID

},
}
baseURI := ctx.Value(net.CtxKeyBaseURI).(string)
Expand Down